Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Apr 2017 20:58:55 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 218979] fix-shebang: add support for install-time fixes (not just patch-time)
Message-ID:  <bug-218979-13@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218979

            Bug ID: 218979
           Summary: fix-shebang: add support for install-time fixes (not
                    just patch-time)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: z7dr6ut7gs@snkmail.com
                CC: freebsd-ports-bugs@FreeBSD.org

Created attachment 182195
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D182195&action=
=3Dedit
[patch] update shebangfix.mk to support stage-time fixes

With the recent more strict checking of shebang, it's more obvious that the=
re
are a number of ports where fixing shebangs at patch time is not sufficient=
.=20
One example is print/tex-xetex which installs files directly from a
distribution tarball during the 'stage' phase.

Attached is an update to shebangfix.mk that supports fixing shebangs during=
 the
'stage' phase.

The gating knob to control it is to define SHEBANG_FILES_INSTALL (relative =
to
${STAGEDIR}${PREFIX} by default) instead of (or in addition to) SHEBANG_FIL=
ES.

It also now supports SHEBANG_FILES_PATCH to be more explicit.  We could
deprecate SHEBANG_FILES, but for now it can be a separate task to replace t=
hem.

I wasn't clear whether to name the new variables as *_INSTALL or *_STAGE.=20
Feedback welcome.  I opted for _INSTALL since it's generally recommended to=
 use
things like post-install rather than post-stage in ports Makefiles.

The premise for the update is pretty simple.  Use the same logic at patch t=
ime
and stage time via .USE.  Operate over a different list of files and in a
different directory (working directory vs. staging directory).

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218979-13>