From nobody Thu Jun 9 19:30:36 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 22B92838D9D for ; Thu, 9 Jun 2022 19:30:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LJvMH6HF5z3Dr5 for ; Thu, 9 Jun 2022 19:30:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B85F82006 for ; Thu, 9 Jun 2022 19:30:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 259JUZLo032919 for ; Thu, 9 Jun 2022 19:30:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 259JUZX2032918 for bugs@FreeBSD.org; Thu, 9 Jun 2022 19:30:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures Date: Thu, 09 Jun 2022 19:30:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654803035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VaZk9IxFCfzwX1bov7+JeKMlxQWixsXYlSrPYJdldQE=; b=cwq6oPHjA6sTFslALAaXeZziNHjjvC0FWrQOmEiyD+H0xfWMfrIP35wMjNORtlik09hSe3 74iPStDMEHqDTSG7ClwQn7U/4wQ0/D0Nrp4lVliVpN2wGXwHP0YrIEh6SpbEuMkjeJ5OLW gFXpAMYs7fDD5uV0GT6ve3LoEqlG0u+Q0QQDHayObWX7WbyaWJ8yLblE4rz9qvugSSAHQn vRtxjttgfUbOqcACOs2Y3r4Uv/buNn2eJHo7EdVX5+ljNczyk1hzz2XcsTv2ZLLSf9xNCG WkqllPhRvcA+oRXWxSWeKjOiDHi9MOnMhJEJm6AnP/0eLyQrIWn6BhGfuUXkYw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654803035; a=rsa-sha256; cv=none; b=WFs3BZlgZ2JSf0yYZ/Xlu38F7nc7+X98wItudW1bfOd1D9Y3OFtLU3F77UJWC5aC5ISYT4 +8vM2ncY+2OrPQZ1kKWGHntWMCY83/swM4p4dz6Dxxw462qqarRXl9lKgPa9+WdeYTqOu8 ICTwE+UycN7aBBvrVGkbGgkgMPiIMMLzvjtqjx+Toz4EV6xKiv8R9LFU/4osKmAbmtMi5q IhlZNMNpW1I7qnGz1g83XLEEGllzSlvMv8vTuqURFs0Favp5WH6jOdgoq0cQ1hpr20fGp2 NL4OdoG0nxieAR2pSYfeNnktprllpJzmngqxQG8oyaaM6EOFHEtYOXBqIuAPlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264578 --- Comment #1 from Ed Maste --- (In reply to Dave Cottlehuber from comment #0) chroot should pass through the return value. (I have no idea whether ${EMULATOR} does, off hand) perhaps: diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr index 0d9202431822..9a89759edc7c 100644 --- a/release/tools/vmimage.subr +++ b/release/tools/vmimage.subr @@ -134,6 +134,9 @@ vm_extra_install_packages() { for p in ${VM_EXTRA_PACKAGES}; do chroot ${DESTDIR} ${EMULATOR} env ASSUME_ALWAYS_YES=3Dyes \ /usr/sbin/pkg install -y ${p} + if [ $? -ne 0 ]; then + err "Package ${p} installation failed" + fi done umount_loop ${DESTDIR}/dev --=20 You are receiving this mail because: You are the assignee for the bug.=