From owner-cvs-all Mon May 7 16:55:56 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 3960B37B422; Mon, 7 May 2001 16:55:49 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f4809YW06462; Tue, 8 May 2001 01:09:34 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f47NtpB14404; Tue, 8 May 2001 00:55:51 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200105072355.f47NtpB14404@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Brian Somers , brian@Awfulhak.org Subject: Re: cvs commit: src/sys/dev/digi digi.c digi.h digi_isa.c digi_p In-Reply-To: Message from John Baldwin of "Mon, 07 May 2001 08:43:40 PDT." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 08 May 2001 00:55:51 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On 07-May-01 John Baldwin wrote: > > > > On 07-May-01 Brian Somers wrote: > >> brian 2001/05/07 04:13:13 PDT > >> > >> Modified files: > >> sys/dev/digi digi.c digi.h digi_isa.c digi_pci.c > >> Log: > >> Change COM_LOCK/COM_UNLOCK to a regular mutex - still conditional on > >> SMP being defined. > > > > Woah. COM_LOCK is a special case due to sio/cy using fast interrupt > > handlers, > > and if digi is using a fast interrupt handler, then it needs to be a spin > > mutex, not a regular mutex. Also, mutexes should be on all the time, not > > just > >#ifdef SMP. Note that COM_LOCK is always defined now. > > Well, having checked the code, it seems you don't use fast interrupt handlers, > so you didn't need COM_LOCK to begin with and you don't need the mutex you are > using right now. tty drivers won't be locked until the tty subsystem is locked > and we figure out how we are going to lock tty data structures. So should I just pull out the mutex stuff for now ? > -- > > John Baldwin -- http://www.FreeBSD.org/~jhb/ > PGP Key: http://www.baldwin.cx/~john/pgpkey.asc > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message