From owner-svn-ports-head@freebsd.org Thu Feb 9 02:12:16 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD51CCD6F96; Thu, 9 Feb 2017 02:12:16 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yw0-x244.google.com (mail-yw0-x244.google.com [IPv6:2607:f8b0:4002:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7D4E11E44; Thu, 9 Feb 2017 02:12:16 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yw0-x244.google.com with SMTP id v73so13353898ywg.1; Wed, 08 Feb 2017 18:12:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=uAEEidbhyqMUMU3KHh67WqRWQLF3dHK4ImLKD3lLvGU=; b=fKB5zLsWjv/qHFKDgdYqaEGCR7pxA0h1z1+ZFeFgngIpFgO8wwR6SzBhZEwKFhoUmu 8NEYrzHJw+zhNIjL1DQ0csYOFr3meAQ/demlPwsln6XAYrjiBjDrLXYA3VIxUEKcQe/V LhRigncrIXeKtFMGUtdXnULljxSNqXB+n7B1YCAtfakmau+UNyeIWXq85/OagSUdKfua +ALG4YiIfmcFCfBEKRlC5OyLxHgYugwaqCv3vPGCH2sB2gCRhC1ujvL+tUpd5nCADn7E yuCyjIfkPku1Gi1/3WHgz8hmo0xCaA9do6OQM18/qEV5pTdvIt5fA5iwmHulGunb9gcF rHgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=uAEEidbhyqMUMU3KHh67WqRWQLF3dHK4ImLKD3lLvGU=; b=F6gyLkf1s1dOzug/OCs9Okj0pacqM718GkxsLHZFZJ/Vwk5cz7agvvg1CUMz7Shtx9 iHDL5cFmQqjfWjZ2bAPnWRyxvtSE9qxPa574oujr0mBxRd2A5Ylrxezta4ei1jc1XMEm 6D5iEtma2IvMSeIf3jGiUtIetdVyTxLWtXfkfZAMGmFrBEaHp0JX7LDgzQtg6PKZuak7 DRzRE431vziCxKCcilxc4vK+4y9nJyclWCpg65zU47RI27LR4uVP0RRCJcjd/kcPcq04 nQ/QxF90krmVhQZdMHbBRpYxxOVQRp0xq5KYSPb0zR7CXy9R2ghe/FRIvXSvoi/+np8o tTsw== X-Gm-Message-State: AMke39knQILqU/blqe9AKmQZkKI82XXD1sCGHNQ1wzKF+qZq6K4vbBlW2wzAh+FPLXQqFLcCVe1NXIZlH4Z+AQ== X-Received: by 10.129.96.137 with SMTP id u131mr538867ywb.302.1486606335412; Wed, 08 Feb 2017 18:12:15 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.38.133 with HTTP; Wed, 8 Feb 2017 18:12:14 -0800 (PST) In-Reply-To: <30EF82F8-D48F-4C40-B979-EF11240B4020@adamw.org> References: <201702090009.v1909xQE041348@repo.freebsd.org> <30EF82F8-D48F-4C40-B979-EF11240B4020@adamw.org> From: Alan Somers Date: Wed, 8 Feb 2017 19:12:14 -0700 X-Google-Sender-Auth: uUshAM-B2l0GRcMdEt70gw7nR0Q Message-ID: Subject: Re: svn commit: r433701 - in head/shells/fish: . files To: Adam Weinberger Cc: Alan Somers , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 02:12:16 -0000 On Wed, Feb 8, 2017 at 5:21 PM, Adam Weinberger wrote: >> On 8 Feb, 2017, at 17:09, Alan Somers wrote: >> >> Author: asomers (src committer) >> Date: Thu Feb 9 00:09:59 2017 >> New Revision: 433701 >> URL: https://svnweb.freebsd.org/changeset/ports/433701 >> >> Log: >> Fix two bugs in shells/fish >> >> 1) The build would fail when DOCS=off (PR 216167) >> 2) Tab completion doesn't work for "mount -t" (PR 216032) >> >> PR: 216167 >> PR: 216032 >> Reported by: Maxfx >> Reported by: David Guyot >> Approved by: brd (ports) > > FWIW, Alan, you could remove that extra-patch-Makefile.in entirely, and pkg would do the right thing regarding the DOCS knob. > > # Adam Good to know. I'll remove it the next time that I update the port. -Alan