Date: Sat, 6 Aug 2011 01:52:18 GMT From: Doug Barton <dougb@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/159540: devel/msp430-libc Makefile has a tiny parsing error Message-ID: <201108060152.p761qIfM002799@freefall.freebsd.org> Resent-Message-ID: <201108060200.p7620Qkt003061@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 159540
>Category: ports
>Synopsis: devel/msp430-libc Makefile has a tiny parsing error
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Aug 06 02:00:26 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Doug Barton
>Release: FreeBSD 8.2-STABLE i386
>Organization:
AAAG
>Environment:
DNA
>Description:
The Makefile has: PORTGCCVERSION= ""
which does the right thing for the post part, but can cause problems
with, for example, 'make describe':
/usr/ports/devel/msp430-libc (msp430-libc-gcc4-1.0.20110612) Error.
BUILD_DEPENDS /usr/ports/devel/msp430-gcc"" -- dependency not found
>How-To-Repeat:
See above
>Fix:
The following patch fixes 'make describe' for me, but should be tested.
Note, this is (somewhat annoyingly) different from how the equivalent
in PLIST_SUB is handled, in part because of how make(1) parses its
variables.
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/msp430-libc/Makefile,v
retrieving revision 1.26
diff -u -r1.26 Makefile
--- Makefile 28 Jul 2011 11:52:43 -0000 1.26
+++ Makefile 6 Aug 2011 01:42:33 -0000
@@ -43,7 +43,7 @@
BUILD_DEPENDS+= ${PKGNAMEPREFIX}gcc:${PORTSDIR}/devel/${PKGNAMEPREFIX}gcc
PLIST_SUB+= GCC3="@comment " GCC4=""
NEEDGCCVERSION= 4
-PORTGCCVERSION= ""
+PORTGCCVERSION=
OTHEGCCVERSION= 3
.elif defined(WITH_GCC3)
PLIST_SUB+= GCC3="" GCC4="@comment "
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108060152.p761qIfM002799>