From owner-p4-projects@FreeBSD.ORG  Fri Jun 12 18:08:56 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4CB311065672; Fri, 12 Jun 2009 18:08:55 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 09D40106566C
	for <perforce@FreeBSD.org>; Fri, 12 Jun 2009 18:08:55 +0000 (UTC)
	(envelope-from truncs@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id EC9918FC21
	for <perforce@FreeBSD.org>; Fri, 12 Jun 2009 18:08:54 +0000 (UTC)
	(envelope-from truncs@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5CI8sLh012850
	for <perforce@FreeBSD.org>; Fri, 12 Jun 2009 18:08:54 GMT
	(envelope-from truncs@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5CI8sIm012848
	for perforce@freebsd.org; Fri, 12 Jun 2009 18:08:54 GMT
	(envelope-from truncs@FreeBSD.org)
Date: Fri, 12 Jun 2009 18:08:54 GMT
Message-Id: <200906121808.n5CI8sIm012848@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	truncs@FreeBSD.org using -f
From: Aditya Sarawgi <truncs@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 164192 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2009 18:08:56 -0000

http://perforce.freebsd.org/chv.cgi?CH=164192

Change 164192 by truncs@aditya on 2009/06/12 18:07:58

	This block should be outside access check as suggested by stas@

Affected files ...

.. //depot/projects/soc2009/soc_ext2fs/src/sys/gnu/fs/ext2fs/ext2_vnops.c#9 edit

Differences ...

==== //depot/projects/soc2009/soc_ext2fs/src/sys/gnu/fs/ext2fs/ext2_vnops.c#9 (text+ko) ====

@@ -379,6 +379,11 @@
 	struct ucred *cred = ap->a_cred;
 	struct thread *td = curthread;
 	int error;
+	/*
+	 * Deny setting of UF flags
+	 */
+	if(vap->va_flags & UF_SETTABLE)
+		return (EOPNOTSUPP);
 
 	/*
 	 * Check for unsettable attributes.
@@ -392,11 +397,7 @@
 	if (vap->va_flags != VNOVAL) {
 		if (vp->v_mount->mnt_flag & MNT_RDONLY)
 			return (EROFS);
-		/* 
-		 * Deny setting of UF_* flags
-		 */ 
-		if(vap->va_flags & UF_SETTABLE)
-			return (EOPNOTSUPP);
+	
 		/*
 		 * Callers may only modify the file flags on objects they
 		 * have VADMIN rights for.