From owner-freebsd-ports-bugs@freebsd.org Sat Feb 22 11:13:53 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 577D2238C20 for ; Sat, 22 Feb 2020 11:13:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48Pm0x1fMyz3FJ7 for ; Sat, 22 Feb 2020 11:13:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3876F238C1F; Sat, 22 Feb 2020 11:13:53 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 380A0238C1E for ; Sat, 22 Feb 2020 11:13:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Pm0w6Hwbz3FHs for ; Sat, 22 Feb 2020 11:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C9863229FB for ; Sat, 22 Feb 2020 11:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01MBDqaJ037948 for ; Sat, 22 Feb 2020 11:13:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01MBDquH037946 for ports-bugs@FreeBSD.org; Sat, 22 Feb 2020 11:13:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 244008] [exp-run] Simplify Mk/bsd.gcc.mk Date: Sat, 22 Feb 2020 11:13:53 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: gerald@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gerald@FreeBSD.org X-Bugzilla-Flags: exp-run+ X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Feb 2020 11:13:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244008 Gerald Pfeifer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Closed Resolution|--- |FIXED --- Comment #2 from Gerald Pfeifer --- Thank you, Antoine! And, grr, I missed to connect this via the commit message: PR: 244008=20 Tested by: antoine (exp-run) Author: gerald Date: Sat Feb 22 10:15:04 2020 New Revision: 526751 URL: https://svnweb.freebsd.org/changeset/ports/526751 Log: Significantly simplify the logic to determine which port (or base version) of GCC to use based on the specification of USE_GCC. This is based on the observation that we now only have a single version of GCC in base, namely GCC 4.2, which is not in ports any longer. And we limit our choice to either the specific version requested or the default version of GCC in the ports tree; i.e., we no longer consider an installed port of any version in between (which is a fringe case extremely few, if any, users would have experienced, and then only outside a clean build environment in any case). Streamline some debugging output accordingly. Overall this removes some 25 lines of largely complex logic. Modified: head/Mk/bsd.gcc.mk --=20 You are receiving this mail because: You are on the CC list for the bug.=