From owner-svn-ports-all@freebsd.org Wed Jan 3 16:38:58 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CE05EA2D21 for ; Wed, 3 Jan 2018 16:38:58 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5FA717AAB9 for ; Wed, 3 Jan 2018 16:38:58 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-io0-x22e.google.com with SMTP id i143so2676654ioa.3 for ; Wed, 03 Jan 2018 08:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=F6y2fLsOSEhNFUZ5edtqqWlJCXveORrM6ILx3/NNQF8=; b=tpMfOkbjpu+SU7ln0nBgHNpa/pm7A8Q82BBpAYrj6cBQWlRPK0qRWFmwcW1Mo0dHYa /Mc6dnZGIkxSDmto94nazU4jIQdbov/RUogzVuKdZuV4Qfy86+EQwPR2XGBYSddmh8Zj wEsXQGTm+uRM/rh6OgCYqtxsULnXEAR/qsFBZAkHKSeptTVgivnY6AUmPPoYRitgSxmd 4KWYGXykoPFTrS9k1PJcLjvbowimgtMxMIraRaw39zXUFfw0o3Upv1ln4tjeoIuv1x01 jOwQMBUfdRzUgpBpXJzufXbuPPTlFzbmHnUHQRx8lurfPkI/9lHiEMankh1KNScS+A7b rSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=F6y2fLsOSEhNFUZ5edtqqWlJCXveORrM6ILx3/NNQF8=; b=i1O6Mpjm2ehKCjbf+NnZ1J9vn2WPLlDPPa4iNafRfBSTnaeiGMFGa0O28WHUpzQosw +jHnQxcGYELAR4RPvbjQ6m+GUKdStdj60K2QK7h4JPyeb1TeHdj9NlbhDlC/Nnhfwr43 AhpSoiQPf1TAQA4YlqtNWe2VSGfLCTPy3p8O7sqTbKSTt69T+/+l9nhmduThXQk49+2b MC+1GD5540VZ6cWVZxxL9nm5bbkuOUdMPyxkhQBBS1q7EcBi7j1OJPzNh5DJ0jIAl70f ZLv11HeJyw6Ugi7PE8x2Vlut3ardZxuRHDTqh8cAcNYhnYfGRUev4PSXDHMiKcqEfuUA 1bVA== X-Gm-Message-State: AKGB3mK9kE9UoQA3U7Qc8Sj+XgjMfoUbO/cZUpD+GVHBkOTKRVzqAslH Jl10I9rnY0UZXrn/iv80x1mASRzR8gRuM+O1gXFqBrxhAuA= X-Google-Smtp-Source: ACJfBotXHG1rJV26NmRG/91O12krhX133mD/4grn7IAFXebQ504M5UzUvDFbGjPBFNYnLL5taNsTZmkdC6qWAgAGLCU= X-Received: by 10.107.19.104 with SMTP id b101mr2276858ioj.297.1514997537480; Wed, 03 Jan 2018 08:38:57 -0800 (PST) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.2.183.7 with HTTP; Wed, 3 Jan 2018 08:38:16 -0800 (PST) In-Reply-To: References: <201801021533.w02FXYPG017753@repo.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Thu, 4 Jan 2018 00:38:16 +0800 X-Google-Sender-Auth: ahuxD8c-CWMaTed7V3zq0Twwm_8 Message-ID: Subject: Re: svn commit: r457878 - head/textproc/rubygem-liquid-tag-parser To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 16:38:58 -0000 On Tue, Jan 2, 2018 at 11:54 PM, Mathieu Arnold wrote: > Le 02/01/2018 =C3=A0 16:33, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > > Author: sunpoet > > Date: Tue Jan 2 15:33:33 2018 > > New Revision: 457878 > > URL: https://svnweb.freebsd.org/changeset/ports/457878 > > > > Log: > > Fix build on Ruby prior to 2.5 > > > > Ruby 2.5 bundled RDoc 6.0.1. Due to unknown RDoc issue, RDoc prior to > > 6.0.0.beta1+ failed to parse the regex in lib/liquid/tag/parser.rb. > > Upstream also set "has_rdoc =3D false" in gemspec. > > > > Modified: > > head/textproc/rubygem-liquid-tag-parser/Makefile > > > > Modified: head/textproc/rubygem-liquid-tag-parser/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/textproc/rubygem-liquid-tag-parser/Makefile Tue Jan 2 > 15:33:28 2018 (r457877) > > +++ head/textproc/rubygem-liquid-tag-parser/Makefile Tue Jan 2 > 15:33:33 2018 (r457878) > > @@ -18,4 +18,6 @@ NO_ARCH=3D yes > > USE_RUBY=3D yes > > USES=3D gem > > > > +NOPORTDOCS=3D yes > > + > > > Setting NOPORTDOCS in a port was never supported, it is a deprecated > variable, set only in make.conf, please revert. If you need to disable > the DOCS option, either do not add it to OPTIONS_DEFINE, or add it to > OPTIONS_EXCLUDE. > > It's a temporary fix to avoid the rdoc issue. from Mk/Uses/gem.mk: .if ${PORT_OPTIONS:MDOCS} RUBYGEM_ARGS+=3D --rdoc --ri .else RUBYGEM_ARGS+=3D --no-rdoc --no-ri .endif I did think of OPTIONS_EXCLUDE but did not know it works 'cos it looks strange when there's no OPTIONS_DEFINE=3DDOCS. But anyway it really works. Thanks! > > -- > Mathieu Arnold > > >