From owner-svn-src-all@FreeBSD.ORG Fri Nov 26 04:26:37 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 689121065670; Fri, 26 Nov 2010 04:26:37 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au [211.29.132.184]) by mx1.freebsd.org (Postfix) with ESMTP id 037A48FC14; Fri, 26 Nov 2010 04:26:36 +0000 (UTC) Received: from c122-106-145-124.carlnfd1.nsw.optusnet.com.au (c122-106-145-124.carlnfd1.nsw.optusnet.com.au [122.106.145.124]) by mail03.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id oAQ4QWnC012551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Nov 2010 15:26:35 +1100 Date: Fri, 26 Nov 2010 15:26:32 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Attilio Rao In-Reply-To: <201011251556.oAPFu5Lg009989@svn.freebsd.org> Message-ID: <20101126144637.S1417@besplex.bde.org> References: <201011251556.oAPFu5Lg009989@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r215821 - head/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2010 04:26:37 -0000 On Thu, 25 Nov 2010, Attilio Rao wrote: > Log: > Add a missing CTL description from CVS revision 1.147. This compounds the bugs in rev.1.147. The description wasn't really missing, since the whole table (CTL_KERN_NAMES) is historical garbage that probably shouldn't exist and certainly shouldn't be added to. > Modified: head/sys/sys/sysctl.h > ============================================================================== > --- head/sys/sys/sysctl.h Thu Nov 25 15:42:33 2010 (r215820) > +++ head/sys/sys/sysctl.h Thu Nov 25 15:56:05 2010 (r215821) > @@ -452,6 +452,7 @@ TAILQ_HEAD(sysctl_ctx_list, sysctl_ctx_e > { "logsigexit", CTLTYPE_INT }, \ > { "iov_max", CTLTYPE_INT }, \ > { "hostuuid", CTLTYPE_STRING }, \ > + { "arc4rand", CTLTYPE_OPAQUE }, \ > } > > /* > The error in rev.1.147 was adding the corresponding sysctl number KERN_ARND 12 years after hard-allocation of sysctl numbers were deprecated and 10 years after they became obsolete. OID_AUTO should have been used in the sysctl declaration, and sysctl.h shouldn't have been touched. Fortunately, KERN_ARND is still not documented in either sysctl.8 or sysctl.3, so it is properly unusable. The sysctl by name "arc4rand" is also undocumented in these man pages. Documentation of the numbers and names in the above man pages seems to stop at logsigexit in sysctl.8 and before that in sysctl.3 (sysctl.8 is easier to use for this comparison but harder to use normally since its strings are mostly unsorted in the same historical order as the numbers). The previous mistakes "hostuid" and "iov_max" visible in the above list are also still not documented in either of these man pages. Some historical dates: 1995: OID_AUTO 1997: sysctlbyname() (before this, OID_AUTO sysctls were only easy to use via sysctl(8) 1998: KERN_LOGSIGEXIT 2007: KERN_ARND 2010: "arc4rand". Bruce