From owner-svn-src-all@FreeBSD.ORG Thu Feb 12 22:06:06 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E94CB386; Thu, 12 Feb 2015 22:06:05 +0000 (UTC) Received: from mail-ig0-x234.google.com (mail-ig0-x234.google.com [IPv6:2607:f8b0:4001:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A5EE32EA; Thu, 12 Feb 2015 22:06:05 +0000 (UTC) Received: by mail-ig0-f180.google.com with SMTP id b16so6946587igk.1; Thu, 12 Feb 2015 14:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=5jWkIe7qc4a6BOQX2dDyE2lljVbcQVxUHxmQh7qqsj0=; b=qfmu75iQNlmWopWFKC3IL7pp6uA2oHH8gUNQkAyOjEVI3H47bSOVAwUBvAbDCn6DMN 7vjTmdaD6Qe/CJsXRrAW1VTs062ECoxAhLQJwcIkcv22nX/w4DarkD0EdaaXi95QK4Wk GYSwVhFAitw/3yEHhtRvTJXb4UOhntnh993hPeYUOU0S4F3WQ5oUCEbMAAROfzFFuZ5o S1tyTMPYc/45KrW3b07sKhRRArTWRj+kRoRzEufSVoctw1i6+t8IwmO/vW9PCQFUqKyA gHCPNg2kI+GFMRoQoE2o5uwmLYNB/ln2lPEVAhHz5oufiaeO7wiyT5zKqpoSrj81e/yN o2Lw== X-Received: by 10.107.158.146 with SMTP id h140mr7536225ioe.27.1423778765031; Thu, 12 Feb 2015 14:06:05 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:5de4:da0f:932c:57df? ([2601:8:ab80:7d6:5de4:da0f:932c:57df]) by mx.google.com with ESMTPSA id sd7sm1982425igb.20.2015.02.12.14.06.04 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Feb 2015 14:06:04 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_400BC6BF-32A8-4232-B469-38FA9E43C759"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r278475 - head/usr.sbin/pw/tests From: Garrett Cooper In-Reply-To: <201502092115.t19LFrEk019578@svn.freebsd.org> Date: Thu, 12 Feb 2015 14:06:02 -0800 Message-Id: <39C8D48F-1962-4393-8FF3-C96DDBF6721E@gmail.com> References: <201502092115.t19LFrEk019578@svn.freebsd.org> To: Brad Davis X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , oneil.rs@gmail.com X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 22:06:06 -0000 --Apple-Mail=_400BC6BF-32A8-4232-B469-38FA9E43C759 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 Hi Brad, On Feb 9, 2015, at 13:15, Brad Davis wrote: > Author: brd (doc committer) > Date: Mon Feb 9 21:15:52 2015 > New Revision: 278475 > URL: https://svnweb.freebsd.org/changeset/base/278475 >=20 > Log: > Add tests for `pw usernext'. >=20 > PR: 197120 > Submitted by: Robert O'Neil > Approved by: will >=20 > Added: > head/usr.sbin/pw/tests/pw_usernext.sh (contents, props changed) > Modified: > head/usr.sbin/pw/tests/Makefile =85 > + var0=3D1 > + LIMIT=3D`jot -r 1 2 10` > + while [ "$var0" -lt "$LIMIT" ] > + do > + atf_check -s exit:0 ${PW} useradd -n test$var0 -g 0 > + var0=3D`expr $var0 + 1` > + done > + atf_check -s exit:0 -o match:"100${LIMIT}:1001}=94 \ This line is incorrect (there=92s a trailing `}` after 1001). Removing it will fix the test, but is assuming that 1001 will always be = the next group correct (it=92s correct in the default install, but IIRC = it wasn=92t correct if you started groups at gid=3D500)? Wouldn=92t it be safer to create a bogus group, get the gid for the = group, then test to ensure that that god is matched? Thanks! --Apple-Mail=_400BC6BF-32A8-4232-B469-38FA9E43C759 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU3SPKAAoJEMZr5QU6S73e/6QH/1HgIs9AuzdL/Ehvh/XI8YL7 pgbLjBYbwm4S/sZt7cMaMhU+idyy54el3Lka5RRccPutdoF+AbG0uQ2FPLzMafoW 26lTVlRNXT7kpc0HWIAhY/z6ru8HG1Hd/Cxs2pLOI1LvEBKiLrDgrb0rnTMAt3hD Yvrk5wsAHR6nCUmNEYzH6s1QSGrOVwKNjMRl5A1O6mlGhPoogH3cLHkinU+dVHzK Ckv/d+ZmAiZHJq1YJ5E51Bd8+xSOGYD+xwQU2CFHdAwycu/2p8OkxIj5DbtccUDl Cpc2Ccykzw3XMZMk/O1KTjeYcA1g1UZdQ9OQJvMEfDGK1MJesrsoJ/biXSFYRPg= =PTxS -----END PGP SIGNATURE----- --Apple-Mail=_400BC6BF-32A8-4232-B469-38FA9E43C759--