From owner-freebsd-current@FreeBSD.ORG  Sun Jun 27 17:30:11 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4B12E16A4CF; Sun, 27 Jun 2004 17:30:11 +0000 (GMT)
Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A8A6C43D1D; Sun, 27 Jun 2004 17:30:10 +0000 (GMT)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from transport.cksoft.de (localhost [127.0.0.1])
	by transport.cksoft.de (Postfix) with ESMTP
	id D0DD81FFDDB; Sun, 27 Jun 2004 19:30:08 +0200 (CEST)
Received: by transport.cksoft.de (Postfix, from userid 66)
	id E6D811FFDD9; Sun, 27 Jun 2004 19:30:06 +0200 (CEST)
Received: by mail.int.zabbadoz.net (Postfix, from userid 1060)
	id B353915384; Sun, 27 Jun 2004 17:29:22 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by mail.int.zabbadoz.net (Postfix) with ESMTP
	id A85FE15329; Sun, 27 Jun 2004 17:29:23 +0000 (UTC)
Date: Sun, 27 Jun 2004 17:29:23 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
In-Reply-To: <20040627160959.GL12007@darkness.comp.waw.pl>
Message-ID: <Pine.BSF.4.53.0406271706340.89503@e0-0.zab2.int.zabbadoz.net>
References: <Pine.BSF.4.21.0406251809530.1679-100000@InterJet.elischer.org>
	<20040627101951.GJ12007@darkness.comp.waw.pl>
	<Pine.BSF.4.53.0406271521050.89503@e0-0.zab2.int.zabbadoz.net>
	<20040627160959.GL12007@darkness.comp.waw.pl>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de
cc: Robert Watson <rwatson@freebsd.org>
cc: Julian Elischer <julian@elischer.org>
cc: "Bjoern A. Zeeb" <bzeeb+freebsd@zabbadoz.net>
cc: FreeBSD current users <current@freebsd.org>
Subject: Re: jail getfsstat patches.
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jun 2004 17:30:11 -0000

On Sun, 27 Jun 2004, Pawel Jakub Dawidek wrote:

> IMHO it should stay as it is, because:

ok.

some more points while skipping through the code a second time:

* could we make this
	strlcpy(sp->f_mntonname, "<restricted>",
  s.th. w/o '<' and '>' ? [] or () would make me feel better as
  those though special characters won't redirect anything in sh
  even if we should never see this.

* in fhstatfs you missed a prison_enforce_statfs call

* some spelling/grammer left to someone else

else looks good to me; didn't check the compat code;
going to see if I can build a kernel and setup some jails on a
test machine to see if it works as well.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT