From owner-freebsd-sparc Sun Dec 29 21:18:26 2002 Delivered-To: freebsd-sparc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCA5137B401; Sun, 29 Dec 2002 21:18:24 -0800 (PST) Received: from HAL9000.homeunix.com (12-232-220-15.client.attbi.com [12.232.220.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id F200A43E4A; Sun, 29 Dec 2002 21:18:23 -0800 (PST) (envelope-from dschultz@uclink.Berkeley.EDU) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.6/8.12.5) with ESMTP id gBU5H63q005785; Sun, 29 Dec 2002 21:17:06 -0800 (PST) (envelope-from dschultz@uclink.Berkeley.EDU) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.6/8.12.5/Submit) id gBU5H5k9005784; Sun, 29 Dec 2002 21:17:05 -0800 (PST) (envelope-from dschultz@uclink.Berkeley.EDU) Date: Sun, 29 Dec 2002 21:17:05 -0800 From: David Schultz To: Kris Kennaway Cc: Mike Barcroft , current@FreeBSD.ORG, sparc64@FreeBSD.ORG Subject: Re: sparc64 tinderbox failure Message-ID: <20021230051705.GA5307@HAL9000.homeunix.com> Mail-Followup-To: Kris Kennaway , Mike Barcroft , current@FreeBSD.ORG, sparc64@FreeBSD.ORG References: <200212300321.gBU3LMWB011861@bowie.private> <20021229202731.B22633@citusc.usc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021229202731.B22633@citusc.usc.edu> Sender: owner-freebsd-sparc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Thus spake Kris Kennaway : > On Mon, Dec 30, 2002 at 03:21:22AM +0000, Mike Barcroft wrote: > > > ===> sbin/swapon > > cc1: warnings being treated as errors > > /tinderbox/sparc64/src/sbin/swapon/swapon.c: In function `swaplist': > > /tinderbox/sparc64/src/sbin/swapon/swapon.c:246: warning: field width is not type int (arg 3) > > Can someone please just fix this (by backing out the offending commit, > if necessary)? Eek, given a 64-bit size_t, the present code leaves 32 bits of it uninitialized in the usual case. The following patch ought to fix the problem; I can't make sure right now because I'm out of town. Index: swapon.c =================================================================== RCS file: /home/ncvs/src/sbin/swapon/swapon.c,v retrieving revision 1.14 diff -u -r1.14 swapon.c --- swapon.c 2002/12/28 23:39:47 1.14 +++ swapon.c 2002/12/30 05:15:54 @@ -211,7 +211,7 @@ size_t mibsize, size; struct xswdev xsw; int mib[16], n, pagesize; - size_t hlen; + int hlen; long blocksize; long long total = 0; long long used = 0; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-sparc" in the body of the message