From owner-freebsd-hackers@FreeBSD.ORG  Mon Jul 12 19:09:46 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 15D2E1065680
	for <freebsd-hackers@freebsd.org>; Mon, 12 Jul 2010 19:09:46 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B4F98FC12
	for <freebsd-hackers@freebsd.org>; Mon, 12 Jul 2010 19:09:45 +0000 (UTC)
Received: (qmail 18209 invoked by uid 399); 12 Jul 2010 19:09:44 -0000
Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 12 Jul 2010 19:09:44 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4C3B6876.9000402@FreeBSD.org>
Date: Mon, 12 Jul 2010 12:09:42 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.1.10) Gecko/20100701 Thunderbird/3.0.5
MIME-Version: 1.0
To: freebsd-hackers@freebsd.org
References: <AANLkTimZIyoQfKGolPiOvzpBMuCQp4VqtBWaTNU3WVoP@mail.gmail.com>
In-Reply-To: <AANLkTimZIyoQfKGolPiOvzpBMuCQp4VqtBWaTNU3WVoP@mail.gmail.com>
X-Enigmail-Version: 1.0.1
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jul 2010 19:09:46 -0000

On 07/09/10 08:11, Garrett Cooper wrote:
> -# UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED!
> +# UNAUTHORIZED CHANGES WILL BE UNCONDITIONALLY REVERTED!

Couple of comments. The above is not a typo, that's the British
spelling. We generally don't change those. (Arguably it adds character
to the project.) :)

The other is more of a question, I'm not sure what the point of these
changes is: ${var:-} The :- parameter substitution kicks in if var is
unset or null, but you're not substituting it with anything.


Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/