From owner-freebsd-stable@FreeBSD.ORG Tue Apr 23 13:46:38 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 33DBB727 for ; Tue, 23 Apr 2013 13:46:38 +0000 (UTC) (envelope-from break19@gmail.com) Received: from mail-yh0-x229.google.com (mail-yh0-x229.google.com [IPv6:2607:f8b0:4002:c01::229]) by mx1.freebsd.org (Postfix) with ESMTP id ED36B1391 for ; Tue, 23 Apr 2013 13:46:37 +0000 (UTC) Received: by mail-yh0-f41.google.com with SMTP id 47so79062yhr.0 for ; Tue, 23 Apr 2013 06:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=7u6zoPQUlPpSoTQuJUu4I0nhDJcHGchwwOLgKCtr7ZI=; b=lhaAQfwIQ1JAvcDErMaz+6aMppWe2UK6JOWKFP2PWFupA8StBeN8YbAw+1zWKSjQw9 dnEck1SukfAwHTpaXEit9U4Q5Zu8KC3Ro2eAT4KkxJe4kktY9e5xWKg15ViJs/lPZN4x lC53jVE23ST+/y6jWMSru6uhiOeRGy+DksH5M1rZle7bi3CaNVH/i8eEnvQSH7mw3FNO j/QtFYUD77SmN+Y4+R4F4/1VMRqfnh/aXqrORUsQeoCcgfYHFB+lHSq2nbwAch3sLXEw 1JvhsRP+9BV3NPsAUlPBU+6EsfQ6QXnDjqv9s1BZ8DAnKO6Nut6bEJhn6oVhy1uoWIkg k5XQ== X-Received: by 10.236.167.103 with SMTP id h67mr19970682yhl.1.1366724797563; Tue, 23 Apr 2013 06:46:37 -0700 (PDT) Received: from [192.168.0.198] (84.sub-70-196-129.myvzw.com. [70.196.129.84]) by mx.google.com with ESMTPS id n6sm8778986yhn.0.2013.04.23.06.46.35 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Apr 2013 06:46:36 -0700 (PDT) Message-ID: <5176904E.5090809@gmail.com> Date: Tue, 23 Apr 2013 08:44:46 -0500 From: Chuck Burns User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: freebsd-stable@freebsd.org Subject: Re: ada(4) and ahci(4) quirk printing References: <20130422051452.GA2148@icarus.home.lan> <51763BF9.2000506@FreeBSD.org> <20130423092602.GA58831@icarus.home.lan> <51765466.4040209@FreeBSD.org> <4D28DBAE46424C268AA22FCDD8657946@multiplay.co.uk> <20130423114722.GA61919@icarus.home.lan> <20130423125144.GA62949@icarus.home.lan> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 13:46:38 -0000 On 4/23/2013 8:15 AM, Tom Evans wrote: > On Tue, Apr 23, 2013 at 1:51 PM, Jeremy Chadwick wrote: >> On Tue, Apr 23, 2013 at 01:20:31PM +0100, Steven Hartland wrote: >>>> 4) camcontrol wouldn't address the need/interest for ahci(4) quirks to >>>> be made available. >>> >>> Why? >> >> Because camcontrol is for CAM. ahci(4) is not part of CAM. The last >> place I'd look for "poking at AHCI" (as in *actual AHCI*) is camcontrol. >> >> This is one of the reasons sysctl exists -- it's a sort of "covers >> everything" tree, on a per-device basis. > > Just on this point, these quirks aren't actually quirks of ahci(4) are > they? They are quirks of the disks that are attached to ahci(4), and > presumably should apply regardless of whether the disk in question is > hooked up to ahci(4), siis(4) or even mps(4). > > To my mind, this means the quirks should belong to da(4), or at the > very least ada(4). ada(4) and da(4) are both manipulated by CAM, so > having this in camcontrol seems logical to me. To clarify, my mind is > completely oblivious of how all this is implemented in software, so > perhaps my mind needs to be changed rather than the code! +1 for sysctl. If you want camcontrol to handle it, then have it view/set the sysctl. -- Chuck Burns