From owner-cvs-all  Sun Oct 10  2:19:50 1999
Delivered-To: cvs-all@freebsd.org
Received: from norn.ca.eu.org (cr965240-b.abtsfd1.bc.wave.home.com [24.113.19.137])
	by hub.freebsd.org (Postfix) with ESMTP
	id E9B7A154DC; Sun, 10 Oct 1999 02:19:39 -0700 (PDT)
	(envelope-from cpiazza@norn.ca.eu.org)
Received: by norn.ca.eu.org (Postfix, from userid 1002)
	id 80F5EA8; Sun, 10 Oct 1999 02:19:36 -0700 (PDT)
Date: Sun, 10 Oct 1999 02:19:36 -0700
From: Chris Piazza <cpiazza@home.net>
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: Sheldon Hearn <sheldonh@uunet.co.za>,
	Chris Piazza <cpiazza@home.net>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/man/man9 style.9
Message-ID: <19991010021936.B276@norn.ca.eu.org>
References: <73957.939546778@axl.noc.iafrica.com> <14180.939546954@critter.freebsd.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0pre1i
In-Reply-To: <14180.939546954@critter.freebsd.dk>
X-Operating-System: FreeBSD 4.0-CURRENT
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

On Sun, Oct 10, 1999 at 11:15:54AM +0200, Poul-Henning Kamp wrote:
> In message <73957.939546778@axl.noc.iafrica.com>, Sheldon Hearn writes:
> >
> >
> >On Sun, 10 Oct 1999 02:04:21 MST, Chris Piazza wrote:
> >
> >> > 	(p = f()) == NULL)
> >> 
> >> Hmm, you're right I guess.  I was reading it as if(...
> >> 
> >> Should I revert this or change it?
> >
> >Changing it and the example below it to if statements would probably
> >make the fragments more consistent with other examples of tests in the
> >style.9 manpage. Whatever you do, just make sure you end up with a
> >consistent style at the end of the day. ;-)
> 
> Apart from the fact that we discourage assignments inside if (...)

Of course two examples 15 or so lines down do exactly that...

-Chris


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message