From owner-svn-src-head@freebsd.org Thu Jun 21 21:52:06 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D52C10015A7; Thu, 21 Jun 2018 21:52:06 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2E33570604; Thu, 21 Jun 2018 21:52:06 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id C061F9FAE; Thu, 21 Jun 2018 21:52:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf0-f47.google.com with SMTP id t2-v6so6473160lfd.6; Thu, 21 Jun 2018 14:52:05 -0700 (PDT) X-Gm-Message-State: APt69E2elRnvORdTsnD0/VRGGb4erQ44kzyd9PKb8Hmv6XrEKzRDd4wz W7sDRTYBclJT6ZA8dBUBpsRewdWRK1xUpKvZD0E= X-Google-Smtp-Source: ADUXVKIb9AjidK6xOrdVyiydWOy7xaRXWCImHnuRfQGUBwjRr5qVIuAGtYry8whkESXyvHk6x5+8bpm4YzxcS4maZ7s= X-Received: by 2002:a2e:575c:: with SMTP id r28-v6mr17311885ljd.51.1529617924365; Thu, 21 Jun 2018 14:52:04 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:8582:0:0:0:0:0 with HTTP; Thu, 21 Jun 2018 14:51:43 -0700 (PDT) In-Reply-To: <201806212150.w5LLo0d3072797@repo.freebsd.org> References: <201806212150.w5LLo0d3072797@repo.freebsd.org> From: Kyle Evans Date: Thu, 21 Jun 2018 16:51:43 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335509 - head/sys/kern To: Kyle Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 21:52:06 -0000 On Thu, Jun 21, 2018 at 4:50 PM, Kyle Evans wrote: > Author: kevans > Date: Thu Jun 21 21:50:00 2018 > New Revision: 335509 > URL: https://svnweb.freebsd.org/changeset/base/335509 > > Log: > subr_hints: Fix acpi unit hinting (at the very least) > > The refactoring in r335479 overlooked the fact that the dynamic kenv can > also be switched to if hintmode == 0. This is problematic because the > checkmethod bits are only ever ran once, but it worked previously because > the use_kenv was a global state and the first lookup would enable it if > occurring after the dynamic environment has been setup. > > Extending our local definition of use_kenv to include all non-STATIC > hintmodes as long as the dynamic_kenv is setup fixes this. We still have > potential issues if the dynamic kenv comes up while we're doing an anchored > search through the environment, but this is not much of a concern right now > because: > > 1.) The dynamic environment comes up super early in boot, just after kmem > > 2.) This is going to get rewritten to provide a safer mechanism for the > anchored searches, ensuring that we continue using the same environment > chain (dynamic env or static fallback) for all anchored search invocations > > Reported by: mmamcy > X-MFC-With: r335479 > Reported by: mmacy*