From owner-svn-ports-all@freebsd.org Wed Aug 8 20:17:31 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 487DB1069B24 for ; Wed, 8 Aug 2018 20:17:31 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yw1-xc32.google.com (mail-yw1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E3A5F91D4F for ; Wed, 8 Aug 2018 20:17:30 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yw1-xc32.google.com with SMTP id l9-v6so2522889ywc.11 for ; Wed, 08 Aug 2018 13:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z29bSDUQfQRDYi/nFRG/sPx36oxt7FRr8nVXuwGQbYw=; b=QGWYmRfbdtuKV3SZk3EJbXEbGJmRopt5BL9Vzzlt6sX5GJk32ye8hAg1VOMu2CWmkW 8oVa3V99bk3/XF85e3MxLBKel/LFRLO6mB9We65PilPNk8PtR8mULwufhnx+rEFg3szl Q+cIMeWj1Pm6lM+7iVQ8qf39OFBC8rjXbdOzhGwYMwd+FefUylyoQczu0UD9ObwDPtuz lR/DplhUrieRSwc5AoxYQ4D1D2iky6RSXXHHD5e3ViUxIDoI3wLd9PqiWGABG+WazkY6 /qKeGCDuvJTLlqVVUJ1h5xCDP9mAwTFxLtvzuntZPr7xQCHMrmaREQoXVYC2CuWrH8wf KKGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z29bSDUQfQRDYi/nFRG/sPx36oxt7FRr8nVXuwGQbYw=; b=AqovFmP2khdlA+cWYHjwvs4Y5wZiyHh+O+Jm6otVmnKpjO8DRBvEdrmrXGjohPnhUP tc+fNJ2Ulp4uX/kC0ddI7G1KmPVWq69hMRhP3I3owVnkUc0C7oLo/+EU2YDZvg33wx+X 8lUB0yh4BqI0BQCJ4PBNxHGxbMi6EzIFkxQ5MTcaD3c7KA0Q9J+t/QGiZolz7h8hr4v1 DYRKc57Z5I5Z4SoS3njb5X+phxXe7imDRhLEaMcFWPAeK/kRXChwAM7KjsBre0h2uox4 bHqhcHX2E+5VFYIqx7BCOi+M1HaMNezBWUb3pCOIoWr17bEB8sDSwtAJ/CmUjcu31BTT GkmA== X-Gm-Message-State: AOUpUlECuVZopU5KyrWwflZyODo339+qbOXyh/uSyRtnN+b15IR/xaHg ljWlHzQ+vwHxjoA/xnoDd9LGLHkhjfnAiZw7dniD9A== X-Google-Smtp-Source: AA+uWPyGE+X6lmCBdWgNI+6GAIX7LkuDVnPhqMG+bbL3lhhTXpSdqthO2HAzmcP2OGdTARvGNd/EhYhBXw0khu/gv38= X-Received: by 2002:a25:ab8f:: with SMTP id v15-v6mr2217221ybi.408.1533759450288; Wed, 08 Aug 2018 13:17:30 -0700 (PDT) MIME-Version: 1.0 References: <201808081953.w78Jr68X078029@repo.freebsd.org> In-Reply-To: <201808081953.w78Jr68X078029@repo.freebsd.org> From: Adam Weinberger Date: Wed, 8 Aug 2018 14:17:14 -0600 Message-ID: Subject: Re: svn commit: r476670 - in head/devel: . rubygem-solve To: zi@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 20:17:31 -0000 On Wed, Aug 8, 2018 at 1:53 PM Ryan Steinmetz wrote: > > Author: zi > Date: Wed Aug 8 19:53:06 2018 > New Revision: 476670 > URL: https://svnweb.freebsd.org/changeset/ports/476670 > > > +COMMENT= A ruby version constraint solver > > > Added: head/devel/rubygem-solve/pkg-descr > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/rubygem-solve/pkg-descr Wed Aug 8 19:53:06 2018 (r476670) > @@ -0,0 +1,3 @@ > +A Ruby version constraint solver. > + > +WWW: https://rubygems.org/gems/solve > Ryan, You've just added a number of ports with uninformative pkg-descrs, and unhelpful COMMENT strings. These aren't merely formalities. Users should be able to read the pkg-descr and understand if it's the right package for them, and COMMENT is the first target for searches. Please, go back over them and, at the very least, expand the pkg-descr files with more information. As a general rule, pkg-descr should NEVER be the same text as the COMMENT. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org