From owner-svn-src-all@freebsd.org Wed May 23 20:09:39 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32A62EB01FD for ; Wed, 23 May 2018 20:09:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA7DA7C3DA for ; Wed, 23 May 2018 20:09:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x230.google.com with SMTP id t23-v6so24310985ioc.10 for ; Wed, 23 May 2018 13:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lL2u5PeAUiP7+B5YpTbO7gp0h4ifITuNitMmgLTE55M=; b=CWqMHccWp9BaNyseIcGmBXaToQfhIn8L6afEI16lN/KOwXIt8kTf72xoNAKvqtk742 8uvflETj9QnGWXRa245GPi5e2LpJV76iWZ4XLF9D7D8S4/0IlNQydhAmCRNV9au6pyJR C+66NrLX2dITKWKPgV72R2xLDLPOG3EnNqnPb8AoXJN8pzvW7jU4JtXdSHp6uHOL5umK 7wSwgCFjS3eYSRDpTpsrrHgGZ1fn5rqqEdUSPwMelcFTbv1OHJ22R3NJFk+ci0m9YA12 dYPBPpu9NfUFNk8tZhOz/JPP2gKAkUoJLgCbpyh9J5MeOzI4TDKyBB6a5skVjQmwChAk Tdrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lL2u5PeAUiP7+B5YpTbO7gp0h4ifITuNitMmgLTE55M=; b=l5Y5sU7AUGzLAELDUCqefGgwO44nPmfc5hvCbdvB36IbDHudHRzpVbsOiviQsVvAzB TGMirXT1n6rDh8e/Dx3coNt/vMrTh0tObm0sp7NHBV+7mmjLh7EebWbku4WXNy7OlLOa kUhH8M5WLgZszRSGkZx+QCpuAWkj+vN9QbBS581p5i53ynsIaU+nuejshtSFKhYs8B8U 9kVvdmYpQox+qMczsp9RpbFhEAVZva1xNLS9RDEUVI41ylX2QS+W/M8X9vJk5n5g4JTW /tz108VtDZ3u5KBOvfhHBurLGl1UhMwCYS4rn0DTh7YaIZ9M5h6Zk7kxM6SAycu2qWbQ I29g== X-Gm-Message-State: ALKqPwf9ROS+td+Ooqq9L8iacI5HLbywrBH2+kNrfhaMvBZjao8vs7q8 aGphcpNAgzdxIXS9+M+phTQNGT08TbBm4unfUOX85w== X-Google-Smtp-Source: ADUXVKJ1yn/b9t5j+lB45R8irFEzoOF1aiSwHbc6tZVqlVpdOoyemT1+rW3Ej8qYxk5L2cakZt2qmgpPsAIKkfV4osA= X-Received: by 2002:a6b:5a0d:: with SMTP id o13-v6mr3932810iob.39.1527106177887; Wed, 23 May 2018 13:09:37 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Wed, 23 May 2018 13:09:37 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201805230739.w4N7d34c062450@repo.freebsd.org> References: <201805230739.w4N7d34c062450@repo.freebsd.org> From: Warner Losh Date: Wed, 23 May 2018 14:09:37 -0600 X-Google-Sender-Auth: XCZcsFYg1XsuIdPVD8Fejj5EQGU Message-ID: Subject: Re: svn commit: r334077 - in head/sbin/devd: . tests To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 20:09:39 -0000 On Wed, May 23, 2018 at 1:39 AM, Eitan Adler wrote: > Author: eadler > Date: Wed May 23 07:39:02 2018 > New Revision: 334077 > URL: https://svnweb.freebsd.org/changeset/base/334077 > > Log: > devd: correct two warnings > > - catching a polymorphic type by value > - "output between 16 and 95 bytes into a destination of size 80" > > Modified: > head/sbin/devd/devd.cc > head/sbin/devd/tests/client_test.c > > Modified: head/sbin/devd/devd.cc > ============================================================ > ================== > --- head/sbin/devd/devd.cc Wed May 23 07:39:00 2018 (r334076) > +++ head/sbin/devd/devd.cc Wed May 23 07:39:02 2018 (r334077) > @@ -1087,7 +1087,7 @@ event_loop(void) > try { > process_event(buffer); > } > - catch (std::length_error e) { > + catch (const std::length_error& e) { > devdlog(LOG_ERR, "Dropping event > %s " > "due to low memory", buffer); > } > > Modified: head/sbin/devd/tests/client_test.c > ============================================================ > ================== > --- head/sbin/devd/tests/client_test.c Wed May 23 07:39:00 2018 > (r334076) > +++ head/sbin/devd/tests/client_test.c Wed May 23 07:39:02 2018 > (r334077) > @@ -50,7 +50,7 @@ create_two_events(void) > FILE *create_stdout; > FILE *destroy_stdout; > char mdname[80]; > - char destroy_cmd[80]; > + char destroy_cmd[95]; > char *error; > I know it's just a test, but 95 seems equally as magical as 80... Warner > create_stdout = popen("mdconfig -a -s 64 -t null", "r"); > >