From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jun 22 16:50:04 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FE02106564A for ; Fri, 22 Jun 2012 16:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7529B8FC0C for ; Fri, 22 Jun 2012 16:50:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5MGo4Jn049460 for ; Fri, 22 Jun 2012 16:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5MGo40x049459; Fri, 22 Jun 2012 16:50:04 GMT (envelope-from gnats) Date: Fri, 22 Jun 2012 16:50:04 GMT Message-Id: <201206221650.q5MGo40x049459@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Michael Scheidell Cc: Subject: Re: ports/169211: new port: emulators/vboxtool, provides effective control of VirtualBox machines X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Michael Scheidell List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2012 16:50:04 -0000 The following reply was made to PR ports/169211; it has been noted by GNATS. From: Michael Scheidell To: Cc: Subject: Re: ports/169211: new port: emulators/vboxtool, provides effective control of VirtualBox machines Date: Fri, 22 Jun 2012 12:47:35 -0400 Pierre: Thanks for contributing to FreeBSD. I am sure that a vboxtool like this will be very handy for the people who need it. A couple of random suggestions: (sed 's/linux/FreeBSD/' *)... like in pkg-message. bash: can you rewrite this using sh? if not, you also need to include bash as a RUN_DEPENDS. /usr/local/ make sure you honor ${PREFIX} and ${LOCALBASE}, one too many // ${WRKSRC}//COPYING.txt X RUN_DEPENDS= ${LOCALBASE}/bin/VBoxManage (skip )${LOCALBASE}/bin/ do_install: ${INSTALL_SCRIPT} -m 0740 will do instead of the extra chmod, right? vboxtool/files/patch-script-vboxtool. make it an .* in and pass it so it can honor %%PREFIX%% and %%LOCALBASE%% vboxtool_conf='/usr/local/etc/vboxtool/vboxtool.conf' in pkg_add/make/ pkg-plist (with @exec, unexec), you will want to install a sample, and cmp it to conf so you don't overwrite users .conf files. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell