From owner-cvs-all Sun Jan 31 04:06:31 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA20380 for cvs-all-outgoing; Sun, 31 Jan 1999 04:06:31 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.204.136.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA20324; Sun, 31 Jan 1999 04:06:20 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.1a/8.9.1) with ESMTP id NAA09688; Sun, 31 Jan 1999 13:06:17 +0100 (CET) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id NAA48108; Sun, 31 Jan 1999 13:06:15 +0100 (MET) Date: Sun, 31 Jan 1999 13:06:15 +0100 From: Eivind Eklund To: Bruce Evans Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, newton@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_socket.c kern_exit.c kern_resource.c Message-ID: <19990131130615.B44499@bitbox.follo.net> References: <199901310356.OAA14507@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <199901310356.OAA14507@godzilla.zeta.org.au>; from Bruce Evans on Sun, Jan 31, 1999 at 02:56:23PM +1100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sun, Jan 31, 1999 at 02:56:23PM +1100, Bruce Evans wrote: > > Modified files: > > sys/kern sys_socket.c kern_exit.c kern_resource.c > > Log: > > Added comments about non-staticization so it doesn't get un-done next > > time someone goes on a staticization binge. > > > > Suggested by: eivind > > This is bogus. Candidates for staticization are determined by inspecting > all system objects and sources for (lack of) cross references using > tools/kernxref and/or grep. grep can do parts of the job, but it is not guaranteed to be correct, given KLDs ability to grovel through the symbol table on their own. kernxref does most of the same work as the tools I'm running for finding staticization candidates, except my tools also come out with a file and line number for the definition. Forcing me to analyze grep output for each symbol that is a candidate for staticization will expand the work with doing a staticization run from a small number of hours to a larger number of days. Knowing myself, this _will_ result in staticization runs not being done. Besides, having comments about why things aren't static makes it easier to understand how the different pieces of the kernel use each other. I consider this a benefit no matter what other utility the comments have. Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message