From owner-svn-src-head@freebsd.org Thu Mar 9 15:45:15 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A998D05627 for ; Thu, 9 Mar 2017 15:45:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C6D3DD70 for ; Thu, 9 Mar 2017 15:45:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id l7so30675207ioe.3 for ; Thu, 09 Mar 2017 07:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=W2XjiLJyLrRHwmo3Z8M7oZ2rHw3FNnn7UAXgRuj+26c=; b=YIhUi0QwaUAM3Z8TgCtPo/ErQD/hQTtn+XWUmfTeEK7+xMs9L3uB9USQ60BMIsJrCo fi78sSyzMMCXdwoxLQ3caVf14ETNGjja243bMpPTtbLNm6v7G9pqLEnWDjz02cSMSUDr Lpay7unOwGXBE/xmEjNUWnSiOGGYos69sEWOPlwSctCXrJFX0mnmWxSAUOFTLCEQ3RnO Yvf/TQ5rPodS3OvHwqvEUp+kqHq90Zpg9Y0E4ZxsVTLX1haqCJJRPpf1zPYQmnGwwcfy rgZQvvCKlEXfOUgM+4eo+jqq9otGQOdIw3Ll3AcTvFhmSdyUtKPGjgmuMVAnuxK5BTn6 TREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=W2XjiLJyLrRHwmo3Z8M7oZ2rHw3FNnn7UAXgRuj+26c=; b=KyW4mby+Aut85vV1rLj5mSG48mIhXUyXCYHCwYjM2eH9UQfqnWaFc/B05bBr8VH/Oc rc7og50rNK3LDgtkI8cg/T5VY1A8lp1fxGYw7tVTcU4/6dFNozFzxeywoTuy6I9N7ctG kW3hmL6sjaGKY8U4R5XCBr1ml0PTYckGA33YmDvzzCG3np7LXhFV39lZb/zKXc6N2oxX 0mAEZiys41G2AdISRdua+R1QOO5/v9zccsHY+xPm/yBfASlOKVsvLeQKPNxCmhcMY7FA oLFR6y3h2fmPr7V3hZ2FnrZdr4Ga+I+yfoLhg1d1Gh7qN8OdjHgUgAVWVNgIMf0i5a9G ltlw== X-Gm-Message-State: AMke39k/hrop6AAeAzQbFTnLzyUshVE2T127jmTpYzvFsswDFejO5reUHnauTNPynCegbufx6TgIQ4+vPRsENw== X-Received: by 10.107.134.94 with SMTP id i91mr11735354iod.0.1489074313964; Thu, 09 Mar 2017 07:45:13 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Thu, 9 Mar 2017 07:45:13 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <6108f2d1-9c13-66e2-7500-7eb035c0a98f@FreeBSD.org> References: <201703091526.v29FQmRG007171@pdx.rh.CN85.dnsmgr.net> <6108f2d1-9c13-66e2-7500-7eb035c0a98f@FreeBSD.org> From: Warner Losh Date: Thu, 9 Mar 2017 08:45:13 -0700 X-Google-Sender-Auth: DsJOem2Y7-C_whELsCOiH34nZhw Message-ID: Subject: Re: svn commit: r314961 - head/usr.bin/localedef To: Pedro Giffuni Cc: rgrimes@freebsd.org, src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 15:45:15 -0000 On Thu, Mar 9, 2017 at 8:37 AM, Pedro Giffuni wrote: > > On 3/9/2017 10:26 AM, Rodney W. Grimes wrote: >>> >>> Author: pfg >>> Date: Thu Mar 9 15:21:03 2017 >>> New Revision: 314961 >>> URL: https://svnweb.freebsd.org/changeset/base/314961 >>> >>> Log: >>> localedef(1): Fix for memory leaks reported by coverity. >>> Also some small cleanups to match better current illumos. >>> CID: 1338540, 1338541, 1338557, 1338566 >>> Obtained from: illumos >>> Discussed with: Yuri Pankov (@Nexenta) >>> MFC after: 5 days >>> >>> Modified: >>> head/usr.bin/localedef/collate.c >>> head/usr.bin/localedef/ctype.c >>> head/usr.bin/localedef/localedef.c >>> head/usr.bin/localedef/localedef.h >>> head/usr.bin/localedef/time.c >>> >>> Modified: head/usr.bin/localedef/collate.c >>> >>> ============================================================================== >>> --- head/usr.bin/localedef/collate.c Thu Mar 9 13:41:57 2017 >>> (r314960) >>> +++ head/usr.bin/localedef/collate.c Thu Mar 9 15:21:03 2017 >>> (r314961) >>> @@ -1,5 +1,5 @@ >>> /* >>> - * Copyright 2010 Nexenta Systems, Inc. All rights reserved. >>> + * Copyright 2017 Nexenta Systems, Inc. >> >> Now this is defanitly a wrong thing to do with a copyright notice, >> always error on the side of OLDEST date, never newest. You have now >> extended Nexenta's claim to 2010 work by 7 years. >> > Which is fine. > Nexenta was so really nice to relicense this from CDDL to BSD, just for us. That was nice of Nexenta. We shouldn't harp on them in return for conducting their business in a way that's different from how we'd conduct ours. The copyright belongs to them. It's their duty to report and mark their works in accordance to their best interests, including complying with bits of the law. We should let them do it because it is none of our concern. We should not repay their kindness with needless whining. Warner