From owner-svn-src-all@freebsd.org Thu Mar 22 12:02:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D74E2F5FA7F; Thu, 22 Mar 2018 12:02:37 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16]) by mx1.freebsd.org (Postfix) with ESMTP id 7599470BC3; Thu, 22 Mar 2018 12:02:36 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from [IPv6:2a02:c7f:1e13:cf00:f91e:df97:532a:2e3f] (unknown [IPv6:2a02:c7f:1e13:cf00:f91e:df97:532a:2e3f]) by fry.fubar.geek.nz (Postfix) with ESMTPSA id 85DF94EBE3; Thu, 22 Mar 2018 12:02:04 +0000 (UTC) From: Andrew Turner Message-Id: <8722C20F-9581-4C58-98D8-86FD0016BC6B@fubar.geek.nz> Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: svn commit: r331306 - head/sys/dev/usb/controller Date: Thu, 22 Mar 2018 12:02:03 +0000 In-Reply-To: <00c43a84-893e-cbd8-ff6d-f7a551ae3beb@selasky.org> Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Hans Petter Selasky References: <201803211517.w2LFHsHf007714@repo.freebsd.org> <898DF1A6-F1D2-474C-92B5-12F65DC71A40@fubar.geek.nz> <00c43a84-893e-cbd8-ff6d-f7a551ae3beb@selasky.org> X-Mailer: Apple Mail (2.3445.5.20) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 12:02:38 -0000 > On 21 Mar 2018, at 21:54, Hans Petter Selasky wrote: >=20 > On 03/21/18 17:45, Andrew Turner wrote: >>> On 21 Mar 2018, at 15:37, Hans Petter Selasky = wrote: >>>=20 >>> On 03/21/18 16:24, Kyle Evans wrote: >>>>> + { >>>>> + .ep_end =3D 7, >>>>> + .ep_fifosz_shift =3D 9, >>>>> + .ep_fifosz_reg =3D MUSB2_VAL_FIFOSZ_512 | = MUSB2_MASK_FIFODB, >>>>> + }, >>>> I'm afraid I'm not familiar with this- why did .ep_fifosz_shift for >>>> this case drop to 9? frx =3D 10 in the temp < 8 case in the = removals of >>>> the following hunks. Mostly curious because the others seemed to = stay >>>> the same. >>>=20 >>> Hi Andrew, >>>=20 >>> It might be an idea to keep the fifosz_shift at 10, else high-speed = BULK traffic won't be double buffered, and this might affect = performance. >> Should the endpoint 1 size also be fixed? The register has it at 4k, = but it wasn=E2=80=99t an 8k buffer. >=20 > No, because High-Speed BULK will only use 512 byte packets, and 4k is = reserved for isochronous, which doesn't need double buffering at the = moment. Ok, in that case should we remove the double buffer flag on endpoint 1? = The Linux driver seems to always use a 512 byte buffer there, and always = doubles the offset increment when the double buffer flag is set. Andrew