From owner-freebsd-bugs Wed Apr 23 10:30:06 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA11560 for bugs-outgoing; Wed, 23 Apr 1997 10:30:06 -0700 (PDT) Received: (from gnats@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA11548; Wed, 23 Apr 1997 10:30:03 -0700 (PDT) Resent-Date: Wed, 23 Apr 1997 10:30:03 -0700 (PDT) Resent-Message-Id: <199704231730.KAA11548@hub.freebsd.org> Resent-From: gnats (GNATS Management) Resent-To: freebsd-bugs Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, charnier@xp11.frmug.org Received: from who.cdrom.com (who.cdrom.com [204.216.27.3]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA11312 for ; Wed, 23 Apr 1997 10:26:31 -0700 (PDT) Received: from frmug.org (frmug-gw.frmug.org [193.56.58.252]) by who.cdrom.com (8.8.5/8.6.11) with ESMTP id KAA20994 for ; Wed, 23 Apr 1997 10:26:20 -0700 (PDT) Received: (from uucp@localhost) by frmug.org (8.8.5/8.8.5/frmug-2.0) with UUCP id WAA23787 for FreeBSD-gnats-submit@freebsd.org; Tue, 22 Apr 1997 22:41:01 +0200 (MET DST) Received: (from charnier@localhost) by xp11.frmug.org (8.8.5/8.8.5/xp11-uucp-1.1) id WAA07143; Tue, 22 Apr 1997 22:33:57 +0200 (CEST) Message-Id: <199704222033.WAA07143@xp11.frmug.org> Date: Tue, 22 Apr 1997 22:33:57 +0200 (CEST) From: Philippe Charnier Reply-To: charnier@xp11.frmug.org To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.2 Subject: bin/3376: incorrect output from kdump Sender: owner-bugs@freebsd.org X-Loop: FreeBSD.org Precedence: bulk >Number: 3376 >Category: bin >Synopsis: incorrect output from kdump >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Apr 23 10:30:02 PDT 1997 >Last-Modified: >Originator: Philippe Charnier >Organization: >Release: FreeBSD 3.0-CURRENT i386 >Environment: >Description: When running kdump, I found: "i" 4848 ksh RET read 1 4848 ksh CALL read(0,0x3498c,0x1) 4848 ksh GIO fd 0 read 1 bytes "t" 4848 ksh RET read 1 4848 ksh CALL read(0,0x3498c,0x1) 4848 ksh GIO fd 0 read 1 bytes <-- should be '1 byte' " <-- \n should be printed " 4848 ksh RET read 1 >How-To-Repeat: $ ktrace /usr/local/bin/ksh $ exit $ >Fix: Index: kdump.c =================================================================== RCS file: /home2h/FreeBSD.cvsroot/src/usr.bin/kdump/kdump.c,v retrieving revision 1.9 diff -u -r1.9 kdump.c --- kdump.c 1997/03/29 04:30:10 1.9 +++ kdump.c 1997/04/22 20:21:27 @@ -368,14 +368,15 @@ else screenwidth = 80; } - printf("fd %d %s %d bytes\n", ktr->ktr_fd, - ktr->ktr_rw == UIO_READ ? "read" : "wrote", datalen); + printf("fd %d %s %d byte%s\n", ktr->ktr_fd, + ktr->ktr_rw == UIO_READ ? "read" : "wrote", datalen, + datalen == 1 ? "" : "s"); if (maxdata && datalen > maxdata) datalen = maxdata; (void)printf(" \""); col = 8; for (;datalen > 0; datalen--, dp++) { - (void) vis(visbuf, *dp, VIS_CSTYLE, *(dp+1)); + (void) vis(visbuf, *dp, VIS_CSTYLE|VIS_NL, *(dp+1)); cp = visbuf; /* * Keep track of printables and >Audit-Trail: >Unformatted: