Date: Wed, 6 Jul 2022 22:35:00 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Matthias Fechner <mfechner@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure Message-ID: <CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw@mail.gmail.com> In-Reply-To: <202206301432.25UEWIi4077084@gitrepo.freebsd.org> References: <202206301432.25UEWIi4077084@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000da822d05e323e179 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner <mfechner@freebsd.org> wrote: > The branch main has been updated by mfechner: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5 > > commit 4671249405c05bb65dfec261eb645081ea72fdf5 > Author: Matthias Fechner <mfechner@FreeBSD.org> > AuthorDate: 2022-06-30 14:28:33 +0000 > Commit: Matthias Fechner <mfechner@FreeBSD.org> > CommitDate: 2022-06-30 14:32:13 +0000 > > net/rubygem-omniauth-auth0: Fix build failure > Fixes a build regression after: > 56e085ca55a831ab56e2e6b417bf230c827fd2e5 > I think this commit is incorrect. I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0) Please provide the error message. Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 [1] is the change of omniauth from ">=1.9<3" to ">=2<3" where security/rubygem-omniauth is 2.1.0 already. I don't know how it can fix build failure. [1] https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0 --- > net/Makefile | 1 + > net/rubygem-omniauth-auth0/Makefile | 2 +- > net/rubygem-omniauth-oauth2-v1/Makefile | 21 +++++++++++++++++++++ > net/rubygem-omniauth-oauth2-v1/distinfo | 3 +++ > net/rubygem-omniauth-oauth2-v1/pkg-descr | 3 +++ > 5 files changed, 29 insertions(+), 1 deletion(-) > > diff --git a/net/Makefile b/net/Makefile > index ff664b428e4c..593acd3099e9 100644 > --- a/net/Makefile > +++ b/net/Makefile > @@ -1335,6 +1335,7 @@ > SUBDIR += rubygem-omniauth-kerberos > SUBDIR += rubygem-omniauth-oauth > SUBDIR += rubygem-omniauth-oauth2 > + SUBDIR += rubygem-omniauth-oauth2-v1 > SUBDIR += rubygem-omniauth-openid > SUBDIR += rubygem-omniauth-salesforce > SUBDIR += rubygem-omniauth-twitter > diff --git a/net/rubygem-omniauth-auth0/Makefile > b/net/rubygem-omniauth-auth0/Makefile > index 3dcbfe3cfd09..3a599be8b787 100644 > --- a/net/rubygem-omniauth-auth0/Makefile > +++ b/net/rubygem-omniauth-auth0/Makefile > @@ -10,7 +10,7 @@ COMMENT= Authentication broker supporting different > identity providers > > LICENSE= MIT > > -RUN_DEPENDS= rubygem-omniauth-oauth2>=1.1:net/rubygem-omniauth-oauth2 > That should be >=1.4<2 to match upstream (~> 1.4). And net/rubygem-omniauth-oauth2 (1.8.0) fits the range. +RUN_DEPENDS= > rubygem-omniauth-oauth2-v1>=1.4<2:net/rubygem-omniauth-oauth2-v1 > > NO_ARCH= yes > USE_RUBY= yes > diff --git a/net/rubygem-omniauth-oauth2-v1/Makefile > b/net/rubygem-omniauth-oauth2-v1/Makefile > new file mode 100644 > index 000000000000..206e479fd106 > --- /dev/null > +++ b/net/rubygem-omniauth-oauth2-v1/Makefile > @@ -0,0 +1,21 @@ > +PORTNAME= omniauth-oauth2 > +PORTVERSION= 1.7.3 > +CATEGORIES= net rubygems > +MASTER_SITES= RG > +PKGNAMESUFFIX= -v1 > + > +MAINTAINER= ruby@FreeBSD.org > +COMMENT= Abstract OAuth2 strategy for OmniAuth > + > +LICENSE= MIT > +LICENSE_FILE= ${WRKSRC}/LICENSE.md > + > +RUN_DEPENDS= rubygem-oauth2>=1.4<3:net/rubygem-oauth2 \ > + rubygem-omniauth>=1.9<3:security/rubygem-omniauth > + > +USES= gem > +USE_RUBY= yes > + > +NO_ARCH= yes > + > +.include <bsd.port.mk> > diff --git a/net/rubygem-omniauth-oauth2-v1/distinfo > b/net/rubygem-omniauth-oauth2-v1/distinfo > new file mode 100644 > index 000000000000..fa8118af6754 > --- /dev/null > +++ b/net/rubygem-omniauth-oauth2-v1/distinfo > @@ -0,0 +1,3 @@ > +TIMESTAMP = 1656597551 > +SHA256 (rubygem/omniauth-oauth2-1.7.3.gem) = > 3f5a8f99fa72e0f91d2abd7475ceb972a4ae67ed59e049f314c0c1bad81f4745 > +SIZE (rubygem/omniauth-oauth2-1.7.3.gem) = 11776 > diff --git a/net/rubygem-omniauth-oauth2-v1/pkg-descr > b/net/rubygem-omniauth-oauth2-v1/pkg-descr > new file mode 100644 > index 000000000000..cb95d71cba5a > --- /dev/null > +++ b/net/rubygem-omniauth-oauth2-v1/pkg-descr > @@ -0,0 +1,3 @@ > +An abstract OAuth2 strategy for OmniAuth. > + > +WWW: https://github.com/omniauth/omniauth-oauth2 > --000000000000da822d05e323e179 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Thu, Jun 30, 2022 at 10:32 PM Matthias= Fechner <<a href=3D"mailto:mfechner@freebsd.org" target=3D"_blank">mfec= hner@freebsd.org</a>> wrote:<br></div><div class=3D"gmail_quote"><blockq= uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p= x solid rgb(204,204,204);padding-left:1ex">The branch main has been updated= by mfechner:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D4671249405c05bb= 65dfec261eb645081ea72fdf5" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3D4671249405c05bb65dfec261eb645081ea72fdf5</= a><br> <br> commit 4671249405c05bb65dfec261eb645081ea72fdf5<br> Author:=C2=A0 =C2=A0 =C2=A0Matthias Fechner <mfechner@FreeBSD.org><br= > AuthorDate: 2022-06-30 14:28:33 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Matthias Fechner <mfechner@FreeBSD.org><br= > CommitDate: 2022-06-30 14:32:13 +0000<br> <br> =C2=A0 =C2=A0 net/rubygem-omniauth-auth0: Fix build failure</blockquote><bl= ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef= t:1px solid rgb(204,204,204);padding-left:1ex"> <br> =C2=A0 =C2=A0 Fixes a build regression after:<br> =C2=A0 =C2=A0 56e085ca55a831ab56e2e6b417bf230c827fd2e5<br></blockquote><div= ><br></div><div>I think this commit is incorrect.</div><div>I could build t= his port successfully=C2=A0with=C2=A0rubygem-omniauth-oauth2 (1.8.0)</div><= div>Please provide the error=C2=A0message.</div><div><br></div><div><div>Fu= rthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 [1] = is the change of=C2=A0omniauth from ">=3D1.9<3" to "&g= t;=3D2<3" where=C2=A0security/rubygem-omniauth is 2.1.0 already.</d= iv><div>I don't know how it can fix build failure.</div><div><br></div>= <div>[1]=C2=A0<a href=3D"https://github.com/omniauth/omniauth-oauth2/compar= e/v1.7.3...v1.8.0" target=3D"_blank">https://github.com/omniauth/omniauth-o= auth2/compare/v1.7.3...v1.8.0</a></div></div><div><br></div><blockquote cla= ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"> ---<br> =C2=A0net/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 1 +<br> =C2=A0net/rubygem-omniauth-auth0/Makefile=C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 +-<= br> =C2=A0net/rubygem-omniauth-oauth2-v1/Makefile=C2=A0 | 21 ++++++++++++++++++= +++<br> =C2=A0net/rubygem-omniauth-oauth2-v1/distinfo=C2=A0 |=C2=A0 3 +++<br> =C2=A0net/rubygem-omniauth-oauth2-v1/pkg-descr |=C2=A0 3 +++<br> =C2=A05 files changed, 29 insertions(+), 1 deletion(-)<br> <br> diff --git a/net/Makefile b/net/Makefile<br> index ff664b428e4c..593acd3099e9 100644<br> --- a/net/Makefile<br> +++ b/net/Makefile<br> @@ -1335,6 +1335,7 @@<br> =C2=A0 =C2=A0 =C2=A0SUBDIR +=3D rubygem-omniauth-kerberos<br> =C2=A0 =C2=A0 =C2=A0SUBDIR +=3D rubygem-omniauth-oauth<br> =C2=A0 =C2=A0 =C2=A0SUBDIR +=3D rubygem-omniauth-oauth2<br> +=C2=A0 =C2=A0 SUBDIR +=3D rubygem-omniauth-oauth2-v1<br> =C2=A0 =C2=A0 =C2=A0SUBDIR +=3D rubygem-omniauth-openid<br> =C2=A0 =C2=A0 =C2=A0SUBDIR +=3D rubygem-omniauth-salesforce<br> =C2=A0 =C2=A0 =C2=A0SUBDIR +=3D rubygem-omniauth-twitter<br> diff --git a/net/rubygem-omniauth-auth0/Makefile b/net/rubygem-omniauth-aut= h0/Makefile<br> index 3dcbfe3cfd09..3a599be8b787 100644<br> --- a/net/rubygem-omniauth-auth0/Makefile<br> +++ b/net/rubygem-omniauth-auth0/Makefile<br> @@ -10,7 +10,7 @@ COMMENT=3D=C2=A0 =C2=A0 =C2=A0 Authentication broker supp= orting different identity providers<br> <br> =C2=A0LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0MIT<br> <br> -RUN_DEPENDS=3D=C2=A0 =C2=A0rubygem-omniauth-oauth2>=3D1.1:net/rubygem-o= mniauth-oauth2<br></blockquote><div><br></div><div>That should be >=3D1.= 4<2 to match upstream (~> 1.4).</div><div>And net/rubygem-omniauth-oa= uth2 (1.8.0) fits the range.</div><div><br></div><blockquote class=3D"gmail= _quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204= ,204);padding-left:1ex"> +RUN_DEPENDS=3D=C2=A0 =C2=A0rubygem-omniauth-oauth2-v1>=3D1.4<2:net/r= ubygem-omniauth-oauth2-v1<br> <br> =C2=A0NO_ARCH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes<br> =C2=A0USE_RUBY=3D=C2=A0 =C2=A0 =C2=A0 yes<br> diff --git a/net/rubygem-omniauth-oauth2-v1/Makefile b/net/rubygem-omniauth= -oauth2-v1/Makefile<br> new file mode 100644<br> index 000000000000..206e479fd106<br> --- /dev/null<br> +++ b/net/rubygem-omniauth-oauth2-v1/Makefile<br> @@ -0,0 +1,21 @@<br> +PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 omniauth-oauth2<br> +PORTVERSION=3D=C2=A0 =C2=A01.7.3<br> +CATEGORIES=3D=C2=A0 =C2=A0 net rubygems<br> +MASTER_SITES=3D=C2=A0 RG<br> +PKGNAMESUFFIX=3D -v1<br> +<br> +MAINTAINER=3D=C2=A0 =C2=A0 ruby@FreeBSD.org<br> +COMMENT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0Abstract OAuth2 strategy for OmniAuth= <br> +<br> +LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0MIT<br> +LICENSE_FILE=3D=C2=A0 ${WRKSRC}/LICENSE.md<br> +<br> +RUN_DEPENDS=3D=C2=A0 =C2=A0rubygem-oauth2>=3D1.4<3:net/rubygem-oauth= 2 \<br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0rubygem-omniauth>= ;=3D1.9<3:security/rubygem-omniauth<br> +<br> +USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gem<br> +USE_RUBY=3D=C2=A0 =C2=A0 =C2=A0 yes<br> +<br> +NO_ARCH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes<br> +<br> +.include <<a href=3D"http://bsd.port.mk" rel=3D"noreferrer" target=3D"_= blank">bsd.port.mk</a>><br> diff --git a/net/rubygem-omniauth-oauth2-v1/distinfo b/net/rubygem-omniauth= -oauth2-v1/distinfo<br> new file mode 100644<br> index 000000000000..fa8118af6754<br> --- /dev/null<br> +++ b/net/rubygem-omniauth-oauth2-v1/distinfo<br> @@ -0,0 +1,3 @@<br> +TIMESTAMP =3D 1656597551<br> +SHA256 (rubygem/omniauth-oauth2-1.7.3.gem) =3D 3f5a8f99fa72e0f91d2abd7475c= eb972a4ae67ed59e049f314c0c1bad81f4745<br> +SIZE (rubygem/omniauth-oauth2-1.7.3.gem) =3D 11776<br> diff --git a/net/rubygem-omniauth-oauth2-v1/pkg-descr b/net/rubygem-omniaut= h-oauth2-v1/pkg-descr<br> new file mode 100644<br> index 000000000000..cb95d71cba5a<br> --- /dev/null<br> +++ b/net/rubygem-omniauth-oauth2-v1/pkg-descr<br> @@ -0,0 +1,3 @@<br> +An abstract OAuth2 strategy for OmniAuth.<br> +<br> +WWW: <a href=3D"https://github.com/omniauth/omniauth-oauth2" rel=3D"norefe= rrer" target=3D"_blank">https://github.com/omniauth/omniauth-oauth2</a><br>; </blockquote></div></div> --000000000000da822d05e323e179--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw>