From nobody Wed Jul 6 15:31:12 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ACDCA1D00745; Wed, 6 Jul 2022 15:31:28 +0000 (UTC) (envelope-from SRS0=OrGx=XL=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from anny.lostinspace.de (anny.lostinspace.de [IPv6:2001:608:a02::33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LdNmp4Zhwz4m2C; Wed, 6 Jul 2022 15:31:22 +0000 (UTC) (envelope-from SRS0=OrGx=XL=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from server.idefix.lan (141-138-067-156.ip-addr.inexio.net [156.67.138.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: idefix@fechner.net) by anny.lostinspace.de (Postfix) with ESMTPSA id 4895492999; Wed, 6 Jul 2022 17:31:13 +0200 (CEST) Received: from [IPV6:2a02:6d40:368b:2201:ccd7:c184:8634:ca00] (unknown [IPv6:2a02:6d40:368b:2201:ccd7:c184:8634:ca00]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by server.idefix.lan (Postfix) with ESMTPSA id 7F70F577C24; Wed, 6 Jul 2022 17:31:12 +0200 (CEST) Content-Type: multipart/alternative; boundary="------------0HxeuPcwScaUg30kIKNvwqj0" Message-ID: Date: Wed, 6 Jul 2022 17:31:12 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure Content-Language: en-US To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202206301432.25UEWIi4077084@gitrepo.freebsd.org> From: Matthias Fechner In-Reply-To: X-Rspamd-Server: anny.lostinspace.de X-Rspamd-Queue-Id: 4LdNmp4Zhwz4m2C X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of "SRS0=OrGx=XL=FreeBSD.org=mfechner@anny.lostinspace.de" designates 2001:608:a02::33 as permitted sender) smtp.mailfrom="SRS0=OrGx=XL=FreeBSD.org=mfechner@anny.lostinspace.de" X-Spamd-Result: default: False [-3.20 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCVD_IN_DNSWL_MED(-0.20)[2001:608:a02::33:from]; BLOCKLISTDE_FAIL(0.00)[2001:608:a02::33:server fail,2a02:6d40:368b:2201:ccd7:c184:8634:ca00:server fail,156.67.138.141:query timed out]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; FORGED_SENDER(0.30)[mfechner@FreeBSD.org,SRS0=OrGx=XL=FreeBSD.org=mfechner@anny.lostinspace.de]; RECEIVED_SPAMHAUS_PBL(0.00)[156.67.138.141:received]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:5539, ipnet:2001:608::/32, country:DE]; RCVD_TLS_ALL(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mfechner@FreeBSD.org,SRS0=OrGx=XL=FreeBSD.org=mfechner@anny.lostinspace.de] X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------0HxeuPcwScaUg30kIKNvwqj0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Sunpoet, Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh: > On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner > wrote: > > The branch main has been updated by mfechner: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5 > > > commit 4671249405c05bb65dfec261eb645081ea72fdf5 > Author:     Matthias Fechner > AuthorDate: 2022-06-30 14:28:33 +0000 > Commit:     Matthias Fechner > CommitDate: 2022-06-30 14:32:13 +0000 > >     net/rubygem-omniauth-auth0: Fix build failure > > >     Fixes a build regression after: >     56e085ca55a831ab56e2e6b417bf230c827fd2e5 > > > I think this commit is incorrect. > I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0) > Please provide the error message. > > Furthermore, the only difference between omniauth-oauth2 1.7.3 and > 1.8.0 [1] is the change of omniauth from ">=1.9<3" to ">=2<3" > where security/rubygem-omniauth is 2.1.0 already. > I don't know how it can fix build failure. > > [1] https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0 And this change caused a race in the dependency tree. I suggest you build www/gitlab-ce, then you will see the error. Or you can also search here to find the correct log file: https://pkg.fechner.net/jail.html?mastername=131amd64-default Here the direct link to the log: https://pkg.fechner.net/build.html?mastername=131amd64-default&build=2022-06-30_10h05m29s Resolving dependencies... Bundler could not find compatible versions for gem "omniauth": In Gemfile: omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on omniauth (~> 1.0) omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on omniauth (~> 2.0) *** Error code 6 This modification was the minimal fix I figured out without the need to rollback a commit. > > > -RUN_DEPENDS= >  rubygem-omniauth-oauth2>=1.1:net/rubygem-omniauth-oauth2 > > > That should be >=1.4<2 to match upstream (~> 1.4). > And net/rubygem-omniauth-oauth2 (1.8.0) fits the range. > > +RUN_DEPENDS= >  rubygem-omniauth-oauth2-v1>=1.4<2:net/rubygem-omniauth-oauth2-v1 > yes and that is what I changed here. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook --------------0HxeuPcwScaUg30kIKNvwqj0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Dear Sunpoet,

Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh:
On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner <mfechner@freebsd.org> wrote:
The branch main has been updated by mfechner:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5

commit 4671249405c05bb65dfec261eb645081ea72fdf5
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2022-06-30 14:28:33 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2022-06-30 14:32:13 +0000

    net/rubygem-omniauth-auth0: Fix build failure

    Fixes a build regression after:
    56e085ca55a831ab56e2e6b417bf230c827fd2e5

I think this commit is incorrect.
I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0)
Please provide the error message.

Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 [1] is the change of omniauth from ">=1.9<3" to ">=2<3" where security/rubygem-omniauth is 2.1.0 already.
I don't know how it can fix build failure.

And this change caused a race in the dependency tree.

I suggest you build www/gitlab-ce, then you will see the error.
Or you can also search here to find the correct log file:
https://pkg.fechner.net/jail.html?mastername=131amd64-default

Here the direct link to the log:
https://pkg.fechner.net/build.html?mastername=131amd64-default&build=2022-06-30_10h05m29s

Resolving dependencies...
Bundler could not find compatible versions for gem "omniauth":
  In Gemfile:
    omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on
      omniauth (~> 1.0)

    omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on
      omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on
        omniauth (~> 2.0)
*** Error code 6

This modification was the minimal fix I figured out without the need to rollback a commit.



-RUN_DEPENDS=   rubygem-omniauth-oauth2>=1.1:net/rubygem-omniauth-oauth2

That should be >=1.4<2 to match upstream (~> 1.4).
And net/rubygem-omniauth-oauth2 (1.8.0) fits the range.

+RUN_DEPENDS=   rubygem-omniauth-oauth2-v1>=1.4<2:net/rubygem-omniauth-oauth2-v1

yes and that is what I changed here.


Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
--------------0HxeuPcwScaUg30kIKNvwqj0--