From owner-svn-src-all@freebsd.org Thu Jan 18 20:02:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33BA0EC00B4; Thu, 18 Jan 2018 20:02:12 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146]) by mx1.freebsd.org (Postfix) with ESMTP id 1C95E7DEA9; Thu, 18 Jan 2018 20:02:10 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from sweettea.beer.town (unknown [76.164.8.130]) by smtp.vangyzen.net (Postfix) with ESMTPSA id A3E625646F; Thu, 18 Jan 2018 14:02:03 -0600 (CST) Subject: Re: svn commit: r327354 - head/sys/vm To: Gleb Smirnoff , Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201712291905.vBTJ57gI072871@repo.freebsd.org> <20180117224054.GO8113@FreeBSD.org> From: Eric van Gyzen Message-ID: <601ee1a2-8f4e-518d-4c86-89871cd652af@vangyzen.net> Date: Thu, 18 Jan 2018 14:01:59 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180117224054.GO8113@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 20:02:12 -0000 On 01/17/2018 16:40, Gleb Smirnoff wrote: > On Fri, Dec 29, 2017 at 07:05:07PM +0000, Konstantin Belousov wrote: > K> Author: kib > K> Date: Fri Dec 29 19:05:07 2017 > K> New Revision: 327354 > K> URL: https://svnweb.freebsd.org/changeset/base/327354 > K> > K> Log: > K> Style. > K> > K> Reviewed by: alc > K> Sponsored by: The FreeBSD Foundation > K> MFC after: 1 week > K> Differential revision: https://reviews.freebsd.org/D13678 > K> > K> Modified: > K> head/sys/vm/vm_swapout.c > K> > K> Modified: head/sys/vm/vm_swapout.c > K> ============================================================================== > K> --- head/sys/vm/vm_swapout.c Fri Dec 29 18:42:55 2017 (r327353) > K> +++ head/sys/vm/vm_swapout.c Fri Dec 29 19:05:07 2017 (r327354) > K> @@ -556,16 +556,14 @@ vm_thread_swapin(struct thread *td) > K> { > K> vm_object_t ksobj; > K> vm_page_t ma[KSTACK_MAX_PAGES]; > K> - int pages; > K> + int a, count, i, j, pages, rv; > K> > K> pages = td->td_kstack_pages; > K> ksobj = td->td_kstack_obj; > K> VM_OBJECT_WLOCK(ksobj); > K> (void)vm_page_grab_pages(ksobj, 0, VM_ALLOC_NORMAL | VM_ALLOC_WIRED, ma, > K> pages); > K> - for (int i = 0; i < pages;) { > K> - int j, a, count, rv; > K> - > K> + for (i = 0; i < pages;) { > K> vm_page_assert_xbusied(ma[i]); > K> if (ma[i]->valid == VM_PAGE_BITS_ALL) { > K> vm_page_xunbusy(ma[i]); > > Yeah, style is sacred, but is there a single person on Earth who would > not agree that moving variables from smaller blocks to function block > reduces readability of the code? I agree that it reduces the readability. Not only that, it also encourages real bugs by allowing access to the variable when it does not make sense. Eric