From owner-cvs-all@FreeBSD.ORG  Thu Mar 29 19:08:15 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 921EC16A408;
	Thu, 29 Mar 2007 19:08:15 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 14DEB13C45A;
	Thu, 29 Mar 2007 19:08:14 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.8/8.13.8) with ESMTP id l2TJ8DvY011205;
	Thu, 29 Mar 2007 23:08:13 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.8/8.13.8/Submit) id l2TJ8DTW011204;
	Thu, 29 Mar 2007 23:08:13 +0400 (MSD) (envelope-from ache)
Date: Thu, 29 Mar 2007 23:08:12 +0400
From: Andrey Chernov <ache@FreeBSD.org>
To: Mike Makonnen <mtm@FreeBSD.org>
Message-ID: <20070329190812.GA11138@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Mike Makonnen <mtm@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200703291055.l2TAtYu4038445@repoman.freebsd.org>
	<20070329172409.GA38703@rogue.navcom.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070329172409.GA38703@rogue.navcom.lan>
User-Agent: Mutt/1.5.14 (2007-02-12)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc network.subr
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2007 19:08:15 -0000

On Thu, Mar 29, 2007 at 08:24:09PM +0300, Mike Makonnen wrote:
> On Thu, Mar 29, 2007 at 10:55:34AM +0000, Andrey A. Chernov wrote:
> > ache        2007-03-29 10:55:34 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     etc                  network.subr 
> >   Log:
> >   Fix get_if_var() with 3 args (i.e. with default)
> >   
> >   All xxx_<ifname> flags are set to empty strings automatically earlier so
> >   eval echo \${${prefix}${_if}${suffix}-${_default}}
> >   not substitute the default but return just the empty string.
> >   Fix it using
> >   eval echo \${${prefix}${_if}${suffix}:-${_default}}
> >   (i.e. treat empty strings as unset)
> >   
> >   The bug manifistates itself with the following warning from checkyesno():
> >   /etc/rc.d/dhclient: WARNING: $background_dhclient is not set properly -
> >   see rc.conf(5)
> >   
> >   Revision  Changes    Path
> >   1.178     +1 -1      src/etc/network.subr
> 
> Please back this out.
> 
> Your change doesn't fix the bug. It only hides it. The bug was fixed in
> rc.d/dhclient v1.28. 

No, the bug was not fixed. It IS in v1.28

-- 
http://ache.pp.ru/