From nobody Mon Oct 11 20:37:21 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 497071810791; Mon, 11 Oct 2021 20:37:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HSrFd1NbMz4qqV; Mon, 11 Oct 2021 20:37:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 627822C58; Mon, 11 Oct 2021 20:37:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) To: Konstantin Belousov , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202110101934.19AJYuIJ019276@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: e81e77c5a055 - main - Enable PPS_SYNC on amd64, arm64 and armv7 Message-ID: Date: Mon, 11 Oct 2021 13:37:21 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 In-Reply-To: <202110101934.19AJYuIJ019276@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 10/10/21 12:34 PM, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e81e77c5a055d1cbf6d6a6f0acbaf443267aa84f > > commit e81e77c5a055d1cbf6d6a6f0acbaf443267aa84f > Author: Konstantin Belousov > AuthorDate: 2021-10-10 12:20:45 +0000 > Commit: Konstantin Belousov > CommitDate: 2021-10-10 19:34:40 +0000 > > Enable PPS_SYNC on amd64, arm64 and armv7 > > Remove the option from NOTES/LINT, and add to NOTES for powerpc and > riscv. > > PR: 259036 > Requested by: John Hay > Discussed with: ian, imp > Sponsored by: The FreeBSD Foundation > MFC after: 1 week Hmm, if the option is MI, why move it out of the MI NOTES? We don't generally remove items from NOTES just because they are enabled by default in GENERIC. That would break the functionality of NOTES where it documents options (and sometimes provides more detail than the 1-liner comments we use in GENERIC). In this case I would have left NOTES as-is and instead added PPS_SYNC to the relevant GENERIC files with a one-line comment leaving the more detailed comment in NOTES. -- John Baldwin