From nobody Wed Apr 29 14:49:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g5Kvr2Myvz6bkxQ for ; Wed, 29 Apr 2026 14:49:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g5Kvq0ZLmz4KTK for ; Wed, 29 Apr 2026 14:49:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r4ABe0PyAncW5BX2Fh/iGoI2xsShECIaJjm25jrDrQU=; b=bwP4aFsMuSJO61bolE/mGvsgRpsNLw4xdllffsrPMEpz7Xk5QTjj5EBfhxsjRA4M1jLamV 9TowSJWqJuPCNDefoiX4naOKd/xFYXd49KjMeCYrmbiR866n1GpbqNuIloYPJ8WPwiLp5j KneIy2+RQ8844N4CdQt14EQW95PO4rc9S8G9+CE9Ev7uPo/In4RdIhj5AzGPVeXYCju6Pg wkMy8evmAdLuAao5zJnNrt/73jb6kI1prKYvcUC753ebjXMUfr3Pjq1pJUHpauf5LwyDfA wSpSqLEVPsyTFXCtDWus0yBy0BdRqkNaKBjTudlRsJlKCGAZySrWe/l+r0mFpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777474183; a=rsa-sha256; cv=none; b=N3XjVFMArkstHkEFFpG0EmlBgX3FA8x2R+Y5OqMcTi5FAP/BXKB4iblBCSWG1YEJGkvndl pM/ZIJaxmadfq9u93NA8oHyk/88lWvT8T7aLNrhvmQtUe7QiMt3GXQfKs6aVQEKYjK27Sh E62n29MwfvsCPzOHVKeH+xKW4Q+kuNtmo3CEvCKHGMHKkipuXbVG1Vp8pOmP2MH8pkDW/o vcSncw6cXAkUKGJnQdel6NCth9hyQLQH7GHl42Q6JNtLPC6pYptuOvONVvfd3cI0cRRWM+ +3v6734FrTUKvKvLfawoMo+t3PmyF2PZ8cL2RB0UOCNolGxkHB9tcyuyxbx7yQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r4ABe0PyAncW5BX2Fh/iGoI2xsShECIaJjm25jrDrQU=; b=SndlTUihH+PvJStebccB3rIFFDtTuwmanNV6IWehbFbVWvOqqoKTm2Nbnc7aZjtJo+Ak6e Cj4fiG2v8qFjZI4kEBA36mZyUjU7+pQgKS/sSQ+huoo/3AUZXv7f0I6SPXKicA5uuq2/Ky Uweughjv56kTF2XGJRV8sk0FxOApZwWp8I1Cgwtpc9uwk1kH8H3mBt9Py9nc9x9BLOX4A0 DDg2esAnb4tniIB3NQFM2i7yTSEVMIY/PF1uOszJBk6DYzZsyYo76e5jis4+CkaxyLu9E6 mn5xNsalbCWCTltZyHh/hsRce8oDmV7OdE5sTsoX4PRkTUDq+/pxuhMp2ivwwQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g5Kvp73LMzlf2 for ; Wed, 29 Apr 2026 14:49:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ae73 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Apr 2026 14:49:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: d60456d859a1 - releng/14.4 - dhclient: Fix reallocation of dhclient script environments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: d60456d859a1830e69c379f9802d50162888e920 Auto-Submitted: auto-generated Date: Wed, 29 Apr 2026 14:49:42 +0000 Message-Id: <69f21a86.3ae73.69e0512f@gitrepo.freebsd.org> The branch releng/14.4 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d60456d859a1830e69c379f9802d50162888e920 commit d60456d859a1830e69c379f9802d50162888e920 Author: Mark Johnston AuthorDate: 2026-04-27 20:56:21 +0000 Commit: Mark Johnston CommitDate: 2026-04-28 20:33:58 +0000 dhclient: Fix reallocation of dhclient script environments When the number of DHCP options exceeds a threshold, script_set_env() will reallocate the environment, stored as an array of pointers. The calculation of the array size failed to multiply by the pointer size, resulting in a smaller than expected buffer which admits out-of-bounds writes. Approved by: so Security: FreeBSD-SA-26:15.dhclient Security: CVE-2026-42511 Reported by: Joshua Rogers of AISLE Research Team (https://aisle.com/) --- sbin/dhclient/dhclient.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/dhclient/dhclient.c b/sbin/dhclient/dhclient.c index 01ef38530cdf..c7a7fcca06ff 100644 --- a/sbin/dhclient/dhclient.c +++ b/sbin/dhclient/dhclient.c @@ -2438,8 +2438,8 @@ script_set_env(struct client_state *client, const char *prefix, char **newscriptEnv; int newscriptEnvsize = client->scriptEnvsize + 50; - newscriptEnv = realloc(client->scriptEnv, - newscriptEnvsize); + newscriptEnv = reallocarray(client->scriptEnv, + newscriptEnvsize, sizeof(char *)); if (newscriptEnv == NULL) { free(client->scriptEnv); client->scriptEnv = NULL;