From owner-freebsd-bugs@freebsd.org Mon Mar 13 17:02:15 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABE8DD0AA4E for ; Mon, 13 Mar 2017 17:02:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 82A911202 for ; Mon, 13 Mar 2017 17:02:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2DH2F1l059244 for ; Mon, 13 Mar 2017 17:02:15 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 217763] [patch] [bsnmpd] MIBIF_ALIAS_SIZE is too low breaking ifXTable Date: Mon, 13 Mar 2017 17:02:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Mar 2017 17:02:15 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217763 Bug ID: 217763 Summary: [patch] [bsnmpd] MIBIF_ALIAS_SIZE is too low breaking ifXTable Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: eugen@freebsd.org Keywords: patch Created attachment 180784 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D180784&action= =3Dedit make ifAlias dynamic FreeBSD allows to assign descriptions to network interfaces by means of ifconfig(8) utility or kernel API utilized by daemons like net/mpd5. sysctl net.ifdescr_maxlen limits maximum description length to 1024 bytes by default, including terminating zero byte. bsnmpd shows these descriptions with ifAlias OIDs in the ifXTable (MIB-II) = but has compiled-in limit MIBIF_ALIAS_SIZE equal to 65 bytes. If an interface h= as longer description (say, 70 bytes), bsnmpd complains: SIOCGIFDESCR (ng7): too long (70) And no description is returned to interface's ifAlias OID. Nevertheless, bsnmpd allocates a buffer of MIBIF_ALIAS_SIZE bytes to every network interface, is it used or not. Attached patch solves these problems and little more: - bsnmpd's network interface buffers for description/ifAlias now have dynam= ic size and allocate exact number of bytes; no extra memory allocated for interfaces having no description; - sysctl net.ifdescr_maxlen is used as limit instead of compiled-in MIBIF_ALIAS_SIZE; changes to this sysctl updated without restart of bsnmpd; - no more strlen() calls on every SNMP request for an ifAlias: we calculate actual size of buffer once, store it and use when needed; - corresponding data moved from struct mibif_private to struct mibif just as suggested by a comment: /* this should be made public */. --=20 You are receiving this mail because: You are the assignee for the bug.=