From owner-svn-src-all@FreeBSD.ORG Fri Sep 19 04:12:42 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C140BE85; Fri, 19 Sep 2014 04:12:42 +0000 (UTC) Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 90A251E7; Fri, 19 Sep 2014 04:12:41 +0000 (UTC) Received: by mail-wi0-f169.google.com with SMTP id hi2so424156wib.4 for ; Thu, 18 Sep 2014 21:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ocVfJ0lVfxguyISmjl76qnluKOVdeyO+vxVQNoL1MRY=; b=QS4FQEd58TpSqK1MuuoQEdT63ZT3gTVFEV4uBj6IGvrn3j4UsUiuzT9M+T7QmOdElh KdDL7fE1SLoSR4EP/0Ey8dBtvY9br72jJb1nZIAIYrS2jv3ewPJoJI9aqpj81DsMFX1M ffAM5nbSyJhXiLtHK9azYCm52V16+14kMCbkAPiDf4SP2fY0pW5MSUmtH6/W4sB35A0x Vuf5hJgCO1XB0zv7JjCIkhAo8JVyi/CtXzGF1ksKhfed7Kvlr/6mdDDI0e4jw2EKltIM 8cqVMveyWrntk9+Jfiq+Z5ohzdTxYlNk3jDKoT4ysv3hb4h51R4sP4ntdeoZ8HjtpRDM zDVA== MIME-Version: 1.0 X-Received: by 10.194.249.164 with SMTP id yv4mr9786483wjc.34.1411099959631; Thu, 18 Sep 2014 21:12:39 -0700 (PDT) Received: by 10.216.159.193 with HTTP; Thu, 18 Sep 2014 21:12:39 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: <201409180309.s8I39Zmh045601@svn.freebsd.org> <20140918051834.GD89442@FreeBSD.org> <20140918060435.GA5856@ns.kevlo.org> <1411024874.128099.168895241.4A95DCA1@webmail.messagingengine.com> Date: Fri, 19 Sep 2014 12:12:39 +0800 Message-ID: Subject: Re: svn commit: r271735 - head/sys/net From: Marcelo Araujo To: Adrian Chadd Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , Bruce Simpson , Gleb Smirnoff , "svn-src-head@freebsd.org" , Kevin Lo X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 04:12:42 -0000 Hello, I made some tests with the implementation from pfsense and it works like a charm with very few modifications. I'm gonna try to make it in two steps. 1) First only submit the vlan(4) and ifconfig(8) changes. 2) Submit the changes on pf(4) and ipfw(8) in a second stage. I'm going to use phabricator to make easier the follow up, byt the way, the patch from pfsense partially was made by rwatson@. I'm gonna add rwatson to the review. Best Regards, 2014-09-18 23:41 GMT+08:00 Marcelo Araujo : > Hello Adrian, > > I have a patch, but it is a hack on PF and some very ugly code. Not > generic at all. > As my hands are dirty now with it, if you don't have too much time, I can > take a look on pfsense implementation. > > Best Regards, > > 2014-09-18 22:32 GMT+08:00 Adrian Chadd : > >> There is in pfsense. >> >> Let me see about twisting some arms again... :) >> >> >> -a >> >> >> On 18 September 2014 00:21, Bruce Simpson wrote: >> > On Thu, 18 Sep 2014, at 07:04, Kevin Lo wrote: >> >> Sorry, I overlooked that. Marcelo has a patch with 802.1p tagging >> >> support, >> >> I thought the patch was committed. >> > >> > I agree the comment change should be reverted. I changed if_ethersubr.c >> > many years ago to decode 802.1p tags into the mbuf packet header if they >> > are present. >> > >> > However, to my knowledge, there is no support (e.g. in the form of a >> > DiffServ / IntServ mapping) further up in the stack. If someone plans to >> > add this, great -- that would be needed for any form of tangible 802.1p >> > support. >> > >> > -- >> > BMS (sent via webmail) >> > >> > > > > -- > > -- > Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ > Power To Server. .\. /_) > > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)