From owner-freebsd-ports-bugs@freebsd.org Fri Nov 30 12:17:54 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B5EB11427AA for ; Fri, 30 Nov 2018 12:17:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C785A7FC72 for ; Fri, 30 Nov 2018 12:17:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8B2E011427A9; Fri, 30 Nov 2018 12:17:53 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79BCA11427A8 for ; Fri, 30 Nov 2018 12:17:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 194217FC71 for ; Fri, 30 Nov 2018 12:17:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 46FF8EAB3 for ; Fri, 30 Nov 2018 12:17:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAUCHqsx032766 for ; Fri, 30 Nov 2018 12:17:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAUCHqqT032758 for ports-bugs@FreeBSD.org; Fri, 30 Nov 2018 12:17:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 233662] graphics/djvulibre: Take MAINTAINER'ship Date: Fri, 30 Nov 2018 12:17:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: C785A7FC72 X-Spamd-Result: default: False [1.82 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.57)[0.567,0]; NEURAL_SPAM_MEDIUM(0.71)[0.714,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.54)[0.543,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 12:17:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233662 --- Comment #1 from Tobias Kortkamp --- (In reply to Lorenzo Salvadore from comment #0) > Cleans the header of the Makefile from the deprecated line "Created > by". It is not deprecated, adding new "Created by" lines is only discouraged. You cannot just change/remove "Created by" headers that you yourself did not add without approval of the original creator, so leave it in or ask mi@ for permission. > Changes a CONFIGURE_ARGS=3D --with... in a CONFIGURE_WITH=3D ... There is no CONFIGURE_WITH variable (there are opt_CONFIGURE_WITH helpers for options only), so this is wrong... How was this tested? Compare `make -V CONFIGURE_ARGS` before and after this change. Using LOCALBASE in this context is wrong too. LOCALBASE is where dependencies come from, PREFIX is where the port installs files into, so it should stay as PREFIX. But passing --with-pkgconfigdir to configure is probably no longer needed anyway due to recent framework changes and fixup-lib-pkgconfig. --=20 You are receiving this mail because: You are the assignee for the bug.=