From owner-svn-src-head@FreeBSD.ORG Tue May 26 18:25:32 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA503B0E; Tue, 26 May 2015 18:25:32 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com [IPv6:2607:f8b0:4001:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4178D5E; Tue, 26 May 2015 18:25:32 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by iebgx4 with SMTP id gx4so98695553ieb.0; Tue, 26 May 2015 11:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=7X6ZXzGrorAPepDkBl7Pj1CnFrKA/KootjOZnbmTnzQ=; b=fiiWtXvI1XG3Y3OrRw2SWtRHCemWgpbnl7OpOZnVabFf5QYQnwFCS0h1Kvn+2nNYAX AccU3YOQCSsOShEKCce7PUR55MWXQbgZlVGUB0qFa2i1DZQuwQ3XqRlx85Z91QiUgZ5S mIpcYrJrlco8q/E2Ihzw0eVmawETfSP69S4AB0HImLrD2ejjOW/kX3FLCO/ySUnUkkq8 zeQHj77dFFjLdlz1G1yxoOXo4rxQBNHWXvpiToZJhIEAQrhRvePLQ7F7pqsfO9ZE4zug evMZWGlGrth22cZ+39HChwwBXrPcTEt6Ce40jTkQox5n20NCOBY8ZL9Gf3Un3xIgNWO/ IkMg== MIME-Version: 1.0 X-Received: by 10.50.73.198 with SMTP id n6mr31282158igv.32.1432664732074; Tue, 26 May 2015 11:25:32 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.38.133 with HTTP; Tue, 26 May 2015 11:25:32 -0700 (PDT) In-Reply-To: <20150526154453.GA73119@FreeBSD.org> References: <201505261319.t4QDJ5Hj045298@svn.freebsd.org> <20150526154453.GA73119@FreeBSD.org> Date: Tue, 26 May 2015 11:25:32 -0700 X-Google-Sender-Auth: 1d_s-pDA7RjRLrVesmKsc4mQClc Message-ID: Subject: Re: svn commit: r283568 - head/sys/net80211 From: Adrian Chadd To: Gleb Smirnoff Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 18:25:33 -0000 On 26 May 2015 at 08:44, Gleb Smirnoff wrote: > On Tue, May 26, 2015 at 08:25:01AM -0700, Adrian Chadd wrote: > A> Hi, > A> > A> We're going to have to move all of the counter API stuff into > A> ieee80211_freebsd.[ch]. > > Well, I put the function in the same file where if_get_counter pointer > is set, so that it can be static. You need distinctive border between > FreeBSD and non-FreeBSD stuff, which right now isn't yet clear. > > I don't mind moving, but looks like the ifnet attachment process, either > the current one or the future one, also needs to be moved to FreeBSD > part of the code. Yeah, the lines got .. blurred. I don't want to go full portability unless someone comes up with a very pressing need - eg, still assume ifnet ,still assume ioctl ,transmit/start, receive, mbufs, etc. But vnets and counter API should be easy to migrate out so netbsd/dragonflybsd can port things. -adrian