Date: Tue, 9 Jan 2007 13:27:18 -0300 From: "Victor Loureiro Lima" <victorloureirolima@gmail.com> To: freebsd-hackers@freebsd.org Subject: Re: [patch] - random(6) Message-ID: <ac00e00a0701090827y34ae9e67peefa342c4d5e0ad4@mail.gmail.com> In-Reply-To: <0CFD7310-5CCE-4346-871A-270F7614919C@foolishgames.com> References: <ac00e00a0611271019o4b436a42sbbb978b4ccddc0d9@mail.gmail.com> <ac00e00a0701081152v79a073adn56ee93ebee3a651a@mail.gmail.com> <0CFD7310-5CCE-4346-871A-270F7614919C@foolishgames.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_6487_3714788.1168360038767 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Probly got stripped of the email somehow, somewhere ;) The patch is attached above... att, victor loureiro lima 2007/1/9, Lucas Holt <luke@foolishgames.com>: > Your patch appeared to get stripped from the mailing list. I would > like to try your patch in MidnightBSD which is based on FreeBSD 6 if > you'd be willing to email it to me. :) > > Luke > > > On Jan 8, 2007, at 2:52 PM, Victor Loureiro Lima wrote: > > > I am forwarding this to -hackers, since I havent got any response from > > the author (seanc@freebsd.org) in months ;/ Maybe someone in here > > could take a few minutes and check this patch out and maybe commit it > > to the source tree > > > > att, > > victor loureiro lima > > > > ---------- Forwarded message ---------- > > From: Victor Loureiro Lima <victorloureirolima@gmail.com> > > Date: 27/11/2006 15:19 > > Subject: [patch] - random(6) > > To: seanc@freebsd.org > > > > > > Hello Sean, > > > > My name is Victor, I've sent you a patch which solved the "bug" in > > which random(6) would > > be way to slow to handle files that are greater than 10MB+, well, I am > > re-sending you that > > same patch with little modifications, do you think you could include > > it in the src tree? > > This patch also increases random(6) performance dramatically even > > when working with small-to-medium file sizes, it should be a good > > addition to the random(6) source tree, and > > its also been extensivelly tested against all features of random(6) > > and it scale really well with big files, for example: > > > > -- > > setuid@zion$ yes | head -200000 > test > > setuid@zion$ time ./random -f test > /dev/null > > 0.257u 0.015s 0:00.27 96.2% 11+14460k 0+0io 0pf+0w > > setuid@zion$ time random -f test > /dev/null > > 187.366u 0.007s 3:07.39 99.9% 10+12945k 0+0io 0pf+0w > > -- > > > > And this was on a Intel Core Duo 2 1.8ghz with 1GB of RAM, with one > > process taking > > less than a second to randomize it all, and the other taking 3 > > minutes, I think its a good > > patch to be applied on the source tree. > > I also took the time to change the man page of random(6) to better > > describe the changes, > > basically removed the BUGS sections (since that bug is solved by the > > patch) and included a new line on the HISTORY section describing my > > contribution to the program :). > > > > Attached are the patches for randomize_fd.c and random.6, also a > > little description of the changes made in randomize_fd.c is in the > > readme file. > > Hope you find that this is patch is commitable, I would appreciate to > > have contributed to FreeBSD even if its just this little contribution > > :) > > > > ciao, > > victor loureiro lima > > _______________________________________________ > > freebsd-hackers@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > > To unsubscribe, send any mail to "freebsd-hackers- > > unsubscribe@freebsd.org" > > > Lucas Holt > Luke@FoolishGames.com > ________________________________________________________ > FoolishGames.com (Jewel Fan Site) > JustJournal.com (Free blogging) > FoolishGames.net (Enemy Territory site) > > > ------=_Part_6487_3714788.1168360038767--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ac00e00a0701090827y34ae9e67peefa342c4d5e0ad4>