From nobody Mon Nov 18 12:26:29 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XsRgn6Q4lz5d2WQ for ; Mon, 18 Nov 2024 12:26:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XsRgn2Fg1z4Qxr for ; Mon, 18 Nov 2024 12:26:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731932789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L3ZFJDELzAW1UmiTjFtgu1advfGIpRbAg6KDEvzMQ/M=; b=gRjgCVlMAx538oLDPF0XAKYNzQ04DqFx455wcz8Lul+0YsD9TAWvngMphgi6qlNW5EmZhi 321enfVBPEpl3gITVwhUKtLC8uylAmSroPzkULmXokPpeFeESxT8IVlEEksSa3UhEOtVYT TAdiKYWDEWb81upiMRqS5R7dLXMnUh9mWGyDrY8FklJjpoKGIXwgz3TxscFR554WAUvfSQ qSZy2qS6UJsvIbXwhh2gMbA8x7IqO8vJAQsRMiY2Zny+nbw631/C9VxxxbeIN7CKCh177M qEXErJbiJnpkC7Z1Xq3IIIwuphrEqtC7aIvuUuiQ/HLHcYla/FMCt+tT/GBgTg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731932789; a=rsa-sha256; cv=none; b=wNQZIbdIncOheo0tJs+okAkE5tqs8Z43bCSwyMfgbbw8bKl673pkfBOXImDAaznIFai6lQ Mpdmse18WcS7NVWsAvHzIfr+h/m3o6aFsXoW04jFRVQbaiUnQQ2JqAbFqzMPpTu9CJ3rQb MvzUAqz4adR6hqP1xNOBbaxQFOy9I1/PQidZx7a0HXizBF+mDIKLIqTEBT3kijDDPZ7cio kPzWls4Np51s936q+uy2XYZiR54z0e5vsheJ3M/4M3M6d2F15g70iqP6aeicui4F/aIefg L7C+U4WbmCbk67cY/h+mNVnY6gdJCwt91NxNn/5X2EitUIAJqM4K34uGbA0nog== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XsRgn1tQMzg3j for ; Mon, 18 Nov 2024 12:26:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4AICQTNq027698 for ; Mon, 18 Nov 2024 12:26:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4AICQTun027697 for bugs@FreeBSD.org; Mon, 18 Nov 2024 12:26:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 282832] makefs zfs creates images with the same guid Date: Mon, 18 Nov 2024 12:26:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: pat@patmaddox.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282832 --- Comment #1 from Pat Maddox --- I see there is a comment [1] about using a fixed seed: /* * Use a fixed seed to provide reproducible pseudo-random numbers f= or * on-disk structures when needed (e.g., GUIDs, ZAP hash salts). */ When are these needed to be reproducible? Should makefs take another flag to produce random GUIDs, or have a note in = the man page that it will always produce the same GUID? I spent quite a bit of = time trying to load two images into bhyve before realizing it was a guid conflic= t. I don't think it should be necessary to import the zpool and reguid it, so = I'd be in favor of a flag if there's some reason the default should always prod= uce the same GUID. [1] https://cgit.freebsd.org/src/tree/usr.sbin/makefs/zfs.c#n787 --=20 You are receiving this mail because: You are the assignee for the bug.=