From owner-freebsd-net@FreeBSD.ORG Tue May 18 18:28:20 2010 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 066821065674; Tue, 18 May 2010 18:28:20 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id BB3838FC1B; Tue, 18 May 2010 18:28:19 +0000 (UTC) Received: by pvg4 with SMTP id 4so45174pvg.13 for ; Tue, 18 May 2010 11:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=ussPSR+DkXhW5Cid/Y4kExpme+Ls1PVvwwXpBZWVRPU=; b=OA8S8KAb4d6y75/iy5LpMUntfk3qpiwJAe8rgiu7TrO5btWLgLnrfQBDmsnC0vaVA+ XFIxN1CGuJOR8+LS8CBaEbqNcxpSDSbtM3H6SIwS1UQsetWMimgsCvzMPJVgdIMlqvOx GOn4D0tF7vjolf2BeFOlFmLo6KGZTfEMfami4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=arF/xiMFGsoIVBtOmbFCRlI7UYvY3BbHa6O3em9vl1ODSId1WKBLmcx8VdQrD7bvEJ BvPSk5JV8nPpruS1g453kmrxHMZPrCgjneQM25sDiRx7L7ZJADMDnZaYyE8EfRfrn9Lc cQX7YWNMAjsXkenb8vikgqHRrxDwOVLiOzrio= Received: by 10.114.164.37 with SMTP id m37mr3688178wae.39.1274207299173; Tue, 18 May 2010 11:28:19 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id d16sm60721108wam.12.2010.05.18.11.28.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 18 May 2010 11:28:18 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 18 May 2010 11:27:08 -0700 From: Pyun YongHyeon Date: Tue, 18 May 2010 11:27:08 -0700 To: John Baldwin Message-ID: <20100518182708.GD5968@michelle.cdnetworks.com> References: <201005181315.37609.jhb@freebsd.org> <20100518173032.GC5968@michelle.cdnetworks.com> <201005181407.33474.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201005181407.33474.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: Navdeep Parhar , net@freebsd.org Subject: Re: Configuring flow control for network interfaces X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2010 18:28:20 -0000 On Tue, May 18, 2010 at 02:07:33PM -0400, John Baldwin wrote: > On Tuesday 18 May 2010 1:30:32 pm Pyun YongHyeon wrote: > > On Tue, May 18, 2010 at 01:15:37PM -0400, John Baldwin wrote: > > > I think it would be useful if we could pick a device-independent interface for > > > configuring flow control on network interfaces, perhaps as media options via > > > ifconfig. I know that the msk(4) driver allows RX and TX flow control to be > > > toggled via the link0 and link1 flags (the manpage for msk(4) needs updating > > > on this topic I think). I have a hack for work to disable TX flow control on > > > > The hack used in e1000phy(4), brgphy(4) and ip1000phy(4) should be > > removed. > > So this looks to actually be different (I was confused). Apparently the > link[012] flags are separate from the flag[012] shared flags for ifmedia. > It does look like the link0 use in these drivers could be replaced by proper > use of IFM_ETH_MASTER media option flag instead. It seems that IFM_ETH_MASTER > is missing from IFM_SUBTYPE_ETHERNET_OPTION_DESCRIPTIONS in ifmedia.h which > would need to be fixed before ifconfig could get/set it. Once that change is > in place I think these drivers could check that flag instead of the IFF_LINK0 > to determine if they are the master. > Right. marius's patch already included that. > > > cxgb(4), but it doesn't use flow control currently. Is flow control ethernet- > > > specific? If so, perhaps we could add two new flags for RX and TX flow > > > control to the Ethernet-specific options in that case? Do folks have other > > > ideas? > > > > > > > AFAIK marius@ is working on it and may have latest patches. > > Ok. Does his patch use Ethernet-specific options or some other approach? > The patch used ethernet-specific options. > -- > John Baldwin