From owner-freebsd-stable@freebsd.org Thu Mar 9 22:49:06 2017 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CC23D05AFF for ; Thu, 9 Mar 2017 22:49:06 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660070.outbound.protection.outlook.com [40.107.66.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D2C5102B; Thu, 9 Mar 2017 22:49:05 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM (10.165.218.133) by YTXPR01MB0191.CANPRD01.PROD.OUTLOOK.COM (10.165.218.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Thu, 9 Mar 2017 22:49:01 +0000 Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) by YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) with mapi id 15.01.0947.022; Thu, 9 Mar 2017 22:49:01 +0000 From: Rick Macklem To: Harry Schmalzbauer , Konstantin Belousov CC: Mark Johnston , FreeBSD Stable Subject: Re: unionfs bugs, a partial patch and some comments [Was: Re: 1-BETA3 Panic: __lockmgr_args: downgrade a recursed lockmgr nfs @ /usr/local/share/deploy-tools/RELENG_11/src/sys/fs/unionfs/union_vnops.c:1905] Thread-Topic: unionfs bugs, a partial patch and some comments [Was: Re: 1-BETA3 Panic: __lockmgr_args: downgrade a recursed lockmgr nfs @ /usr/local/share/deploy-tools/RELENG_11/src/sys/fs/unionfs/union_vnops.c:1905] Thread-Index: AQHR8Usp3UC6l4vlEEOdyPFAeIRbFKBAJI+AgAA/AgCAA/TscIAA8igAgAiYa2KABCvkAIAZfWvFgR8RkACAAGUjgIAAESQAgAAy89uAABLyAIAAlXuAgAJ5ghk= Date: Thu, 9 Mar 2017 22:49:01 +0000 Message-ID: References: <57A9A6C0.9060609@omnilan.de> <20160812123950.GO83214@kib.kiev.ua> <57B8793E.4070004@omnilan.de> <58BEAAAC.4090303@omnilan.de> <58BEFF83.9010906@omnilan.de> <58BF0DE4.1020300@omnilan.de> <20170307235550.GP30979@kib.kiev.ua>,<58BFC5EB.8020905@omnilan.de> In-Reply-To: <58BFC5EB.8020905@omnilan.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=uoguelph.ca; x-ms-office365-filtering-correlation-id: 5c816aaf-05c9-4cd8-fdfc-08d4673e7b38 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:YTXPR01MB0191; x-microsoft-exchange-diagnostics: 1; YTXPR01MB0191; 7:hlq96HO6HaImVdHUc5rirO1NSIMj9gPpVJ6QxMPLhixv+11y9ivym9lpje14LLfEUSMpwcqN0RP1XdAxmt2I7z3iub8uWdSA+FjKbYEOzp+n7adnB1PiyE06mcec4FOCp0yPENNV1Nzo8JOqVEZoCgJj/45GK9mcTnuZ8/WkFp76qM3R/zI62lzhp/SPrsgtlEs1Y6xaxqoNukKrqnK61cwVveSV/VY3MBw8bJd1I62+l4AKjlyUCKtilbmfdR6qZtjhfzzVO4yOvxAclf8QoaJHitHeAEOHeVHoghtiyfjmDdoEXZEM4j3xbaX90E+Icb35Yv8vathrt+LuXpHepw== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(244540007438412)(75325880899374); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(20161123558025)(6072148); SRVR:YTXPR01MB0191; BCL:0; PCL:0; RULEID:; SRVR:YTXPR01MB0191; x-forefront-prvs: 0241D5F98C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(39450400003)(24454002)(55016002)(6506006)(77096006)(7696004)(53936002)(2950100002)(6306002)(54906002)(189998001)(9686003)(2906002)(6436002)(33656002)(106116001)(6246003)(38730400002)(305945005)(39060400002)(2900100001)(102836003)(5660300001)(74482002)(4326008)(74316002)(8676002)(8936002)(81166006)(76176999)(93886004)(54356999)(50986999)(122556002)(229853002)(3660700001)(3280700002)(86362001)(5890100001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR01MB0191; H:YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2017 22:49:01.8423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR01MB0191 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 22:49:06 -0000 Konstantin Belousov wrote: > I did not touched unionfs, and have no plans to. It is equally broken in > all relevant versions of FreeBSD. Heh, heh. I chuckled when I read this. I think he's trying to say "it proba= bly won't ever be fixed". My understanding is that it would require a major red= esign of the FreeBSD VFS to make it fully stackable to fix unionfs and that isn't= happening anytime soon... Harry Schmalzbauer wrote: > In 2016 I did some tests with 11.0-Beta1, where this thread origins, and > Rick kindly looked into it and provided the following patch: > https://lists.freebsd.org/pipermail/freebsd-stable/attachments/20160818/d= 1d1691d/attachment.obj > (Explanation: > https://lists.freebsd.org/pipermail/freebsd-stable/2016-August/085294.htm= l) Yep, I am guilty of creating this patch. All it tried to do was fix the cra= sh. I don't know why a debug kernel with the patch crashes, but I might try and reproduce that. > Picture has changed, the machine daedlocked over night. So it does have > a significant influence, but unfortunately isn't the real solution. So, do you mean there is no longer any unionfs mount on the machine and it still hangs? If yes, then this should be looked at. rick