From owner-svn-src-projects@FreeBSD.ORG  Tue Oct 23 16:44:51 2012
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C4ED4527;
 Tue, 23 Oct 2012 16:44:51 +0000 (UTC)
 (envelope-from grehan@freebsd.org)
Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12])
 by mx1.freebsd.org (Postfix) with ESMTP id 726C28FC17;
 Tue, 23 Oct 2012 16:44:51 +0000 (UTC)
Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57])
 by alto.onthenet.com.au (Postfix) with ESMTPS id C95CC11CCF;
 Wed, 24 Oct 2012 02:44:49 +1000 (EST)
Received: from Peter-Grehans-MacBook-Pro.local
 (c-67-190-8-21.hsd1.co.comcast.net [67.190.8.21])
 by dommail.onthenet.com.au (MOS 4.2.4-GA)
 with ESMTP id BHF78765 (AUTH peterg@ptree32.com.au);
 Wed, 24 Oct 2012 02:44:40 +1000
Message-ID: <5086C976.9060705@freebsd.org>
Date: Tue, 23 Oct 2012 10:44:38 -0600
From: Peter Grehan <grehan@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20
MIME-Version: 1.0
To: Jilles Tjoelker <jilles@stack.nl>
Subject: Re: svn commit: r241744 - projects/bhyve/usr.sbin/bhyve
References: <201210191811.q9JIBIQu049356@svn.freebsd.org>
 <20121021121006.GA96141@stack.nl> <5085D433.4020101@freebsd.org>
 <20121023095549.GA27951@stack.nl>
In-Reply-To: <20121023095549.GA27951@stack.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Junkmail-Info: RCVD_IN_SORBS_DUL,RDNS_DYNAMIC,SPF_SOFTFAIL
X-Junkmail-Status: score=24/51, host=dommail.onthenet.com.au
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 16:44:51 -0000

On 10/23/12 3:55 AM, Jilles Tjoelker wrote:
> On Mon, Oct 22, 2012 at 05:18:11PM -0600, Peter Grehan wrote:
>>> Case 4 looks wrong. A 32-bit write clears the top 32 bits of the
>>> register instead of preserving them.
>
>>    Yep, you're right. How about:
>
>>   >  +	case 4:
>>   >  +		val = (reg & ~0xffffffffUL) | (operand & 0xffffffffUL);
>>   >  +		break;
>
> I think you mean:
> 	val = operand &  0xffffffffUL;
>
> Right?

  Don't think so - the high 32 bits of the target register need to be 
or'd in, as you originally mentioned.

later,

Peter.