From owner-freebsd-mips@FreeBSD.ORG Mon Oct 17 14:56:52 2011 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 172DD10656D0; Mon, 17 Oct 2011 14:56:52 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8485E8FC0C; Mon, 17 Oct 2011 14:56:51 +0000 (UTC) Received: by ywm3 with SMTP id 3so1754355ywm.13 for ; Mon, 17 Oct 2011 07:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=YNzO99xDiOkTmM7XjTG9mfJmmWah4tEsmrh4jtvR5MU=; b=BkzIEE4zlzNG0tCMn7/5Wyo8QmucsXujjxjTgC5gRPmQG18RdCRGBmk7XbVzm43lWt 8QAsn7qMID6HE90R2u2vxJn+DukqCWckLZEG9WxdPph5HmfwZBNwPbbiCm5QtZlReDYm 9oQe/b4Nd5WNz82PBkdSC0x5J4aq3SiCaA7o0= MIME-Version: 1.0 Received: by 10.236.178.41 with SMTP id e29mr26540757yhm.117.1318863411024; Mon, 17 Oct 2011 07:56:51 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.236.95.147 with HTTP; Mon, 17 Oct 2011 07:56:50 -0700 (PDT) In-Reply-To: References: <20111002110331.GF1511@deviant.kiev.zoral.com.ua> Date: Mon, 17 Oct 2011 22:56:50 +0800 X-Google-Sender-Auth: EViK8lxD2i2emzgZCS1Ws88U4ks Message-ID: From: Adrian Chadd To: "Jayachandran C." Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: svn commit: r225892 - head/sys/mips/mips X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2011 14:56:52 -0000 On 17 October 2011 22:18, Jayachandran C. wrote: >> The patch does not cause any further problems =A0for me on XLR/XLP - I >> have been testing it for a few days. =A0But I don't really have a >> testcase for the issue you see. > > If there are no objections, I'm planning to check this in. > > =A0I can keep the two if(!busy) blocks in cpu_idle() commented if you > prefer, and that should give the same behavior as you are seeing now. I'm happy for you to check it in. I'll do some further testing in my branch and see if I can figure out why it isn't working for me. I've also found the relevant bits in the mips24k programming pdfs which talk about the Config7 bit which indiciates whether wait will break if a mask interrupt is asserted or not. That may be good to include at a later date. (But my SoCs don't have that feature, so we still need this WAR.) Adrian