From owner-svn-src-head@freebsd.org Wed May 18 05:22:20 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD369B40FB3; Wed, 18 May 2016 05:22:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 85CCB1121; Wed, 18 May 2016 05:22:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pa0-x232.google.com with SMTP id gj5so13874291pac.2; Tue, 17 May 2016 22:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oi8bApsql9zbv9lc8vFyc5ogAUnj/hirAaHAP34782A=; b=aJzEiuaBlnxNJ3HKPHR1pCGeUvF8dxewCwFB9buQeevi3vne5I+8g9dMrF3EN2QeG3 +CYeULxSg4X2d1ymeJxT1QvG6RwgfN8Z/t+WIsDeSG1OJ9K5lpLah0n4suXHzhaLpeLI PShmcpfyYrmmcVlcpmnBNsDQi/ob9TzqTzvoVjj4CEsz4sdeaiw12tNd9KfCxW8a966f p16GpGjAJBGLA5HQULlQFasDyD04UWiQwZ6VtMv2gvNQn5QwInEkiYKLYhi16LwpV6Y1 4EP7m3vGSUq0ywLzSqZhVAgji/YhArs7FA1N1EKNLt7hrMXEEwfd9IzgYYVjUXBPcFIG epQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oi8bApsql9zbv9lc8vFyc5ogAUnj/hirAaHAP34782A=; b=T+zSHf/R2Mkh1x6hGQ7q97XPGbri5c+/h0a//z7EKpe4wOZZ3KMJHgj4Egv/WCG8I9 ILK60tzX3vcNt+GvcVHMK3KAYc6DIhcV/qdqe+xC7SU6klDsj+rTt2jBKAQ8YMATF52H 6FEVIm51MqDg3vXG47aRQYxXvarnxieNPrtz9ypf1HIGeSy0xvpVvTvvxoszUi7GDZBo iyGmUIesVwoUhpAIewHrguXjbFRnRaWGLfYOUPHqxp/RdS6ymT5fQqlgrjiKP2Q0MAp9 5QQHb4ACV0sfWnRCegJLz3D5NbMqONIjFgOrXNIvsNvpV5ueqyB3oj+wh7tbW2nY+VAm EEjg== X-Gm-Message-State: AOPr4FXZ8mmc+LmyihsWQUxOGJCtCmLICirAz4uwTfppiDT1kPzlGN0rugKYpK1pUV0nkQ== X-Received: by 10.66.177.16 with SMTP id cm16mr7896290pac.23.1463548939991; Tue, 17 May 2016 22:22:19 -0700 (PDT) Received: from [21.177.199.178] ([172.56.42.6]) by smtp.gmail.com with ESMTPSA id z63sm8616269pfb.47.2016.05.17.22.22.18 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 May 2016 22:22:19 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r300110 - head/sys/kern From: NGie Cooper X-Mailer: iPhone Mail (13F69) In-Reply-To: <201605180355.u4I3tskK012821@repo.freebsd.org> Date: Tue, 17 May 2016 22:22:18 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7D442C5C-E059-40A5-887C-55840BE94425@gmail.com> References: <201605180355.u4I3tskK012821@repo.freebsd.org> To: Mark Johnston X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 05:22:20 -0000 > On May 17, 2016, at 20:55, Mark Johnston wrote: >=20 > Author: markj > Date: Wed May 18 03:55:54 2016 > New Revision: 300110 > URL: https://svnweb.freebsd.org/changeset/base/300110 >=20 > Log: > Do not acquire the thread lock in hardclock_cnt() unless needed. >=20 > This function only sets thread flags if a SIGPROF or SIGVTALRM timer > has fired, which is almost never the case. >=20 > MFC after: 2 weeks >=20 > Modified: > head/sys/kern/kern_clock.c >=20 > Modified: head/sys/kern/kern_clock.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/kern/kern_clock.c Wed May 18 03:50:21 2016 (r300109) > +++ head/sys/kern/kern_clock.c Wed May 18 03:55:54 2016 (r300110) > @@ -570,9 +570,11 @@ hardclock_cnt(int cnt, int usermode) > flags |=3D TDF_PROFPEND | TDF_ASTPENDING; > PROC_ITIMUNLOCK(p); > } > - thread_lock(td); > - td->td_flags |=3D flags; > - thread_unlock(td); > + if (flags !=3D 0) { > + thread_lock(td); > + td->td_flags |=3D flags; > + thread_unlock(td); > + } Use predict_false? >=20 > #ifdef HWPMC_HOOKS > if (PMC_CPU_HAS_SAMPLES(PCPU_GET(cpuid))) >=20