From owner-svn-src-user@FreeBSD.ORG Wed Aug 24 07:00:00 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBF65106566B; Wed, 24 Aug 2011 07:00:00 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id B6DAC8FC16; Wed, 24 Aug 2011 07:00:00 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p7O700xK037783; Wed, 24 Aug 2011 07:00:00 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p7O6xxvr037781; Wed, 24 Aug 2011 06:59:59 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201108240659.p7O6xxvr037781@svn.freebsd.org> From: Adrian Chadd Date: Wed, 24 Aug 2011 06:59:59 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r225132 - user/adrian/if_ath_tx/sys/dev/ath X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2011 07:00:00 -0000 Author: adrian Date: Wed Aug 24 06:59:59 2011 New Revision: 225132 URL: http://svn.freebsd.org/changeset/base/225132 Log: Add a comment describing what may occur during retries. Another thing to sort out before this is merged into -HEAD. Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 06:57:29 2011 (r225131) +++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 06:59:59 2011 (r225132) @@ -1907,10 +1907,13 @@ _ath_getbuf_locked(struct ath_softc *sc) * be again passed through the descriptor setup/chain routines * so the link is correct. * - * XXX TODO: the source buffer is still valid; so the mbuf - * XXX will be freed when that buffer is freed! The bf callback - * XXX will be called too, etc, etc. - * XXX so the caller must handle this somehow! + * The caller must free the buffer using ath_freebuf(). + * + * XXX TODO: this call shouldn't fail as it'll cause packet loss + * XXX in the TX pathway when retries are needed. + * XXX Figure out how to keep some buffers free, or factor the + * XXX number of busy buffers into the xmit path (ath_start()) + * XXX so we don't over-commit. */ struct ath_buf * ath_buf_clone(struct ath_softc *sc, const struct ath_buf *bf)