Date: Fri, 9 Dec 2005 15:09:07 +0200 From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> To: pav@FreeBSD.org Cc: freebsd-ports-bugs@FreeBSD.org, dougb@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: ports/90070: [MAINTAINER] mail/rabl_server: per sougb request, use "new style" RC script Message-ID: <20051209150907.1725f4c9@it.buh.tecnik93.com> In-Reply-To: <1134131789.28991.24.camel@pav.hide.vol.cz> References: <200512090922.jB99MYbH094744@freefall.freebsd.org> <20051209143235.79632f96@it.buh.tecnik93.com> <1134131789.28991.24.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 09 Dec 2005 13:36:29 +0100
Pav Lucistnik <pav@FreeBSD.org> wrote:
> > > Synopsis: [MAINTAINER] mail/rabl_server: per sougb request, use
> > > "new style" RC script
> > >
> > > State-Changed-From-To: open->feedback
> > > State-Changed-By: pav
> > > State-Changed-When: Fri Dec 9 09:22:05 GMT 2005
> > > State-Changed-Why:
> > > Why would you want to do this? USE_RC_SUBR is somehow deficient
> > > with new rcNG infrastructure in recent -CURRENT?
> >
> > Posted on ports@ (Subject: USE_RC_SUBR and local_startup scripts in
> > the base rcorder), waited a few days to be told if I'm a stupid or a
> > genius :), no replies, assumed I'm right, so start sending prs.
> >
> > USE_RC_SUBR basically does 2 things:
> > - performs substitutions on ${USE_RC_SUBR}
> > - installs the files in ${USE_RC_SUBR} with .sh extension
> > So even if you have files/rc_script.in besides files/rc_script.sh.in
> > (so that the substitutions can be performed) it will be installed
> > with .sh extension.
>
> And with new dougb's rcNG, rc scripts in /usr/local/etc/rc.d now must
> be without .sh extension?
In dougb's words:
>>> The rc.subr system treats scripts named foo.sh differently than
> scripts named foo. The former are actually sourced into the rc
> environment, which can cause problems if there are errors in the
> script, it overwrites a global variable used elsewhere, etc. Thus, it
> is better to install the script as foo instead of foo.sh.
And the example he provided install non .sh on HEAD; unfortunately the
port from his example doesn't USE_RC_SUBR macro.
> This is absolutely something that must be fixed in the infrastructure,
> not in every port over and over again.
My point exactly. And, as I've said, I'm willing to work on this; I
could (manually) check the USE_RC_SUBR ports over the weekend to see
what kind of rc script they're using. But I need to know which way to
go: renaming non-RCng scripts to *.sh, etc., or I could try to convert
them to RCmng (but this should be done but maintainers, as they know
better what to REQUIRE, etc.)
--
IOnut - Unregistered ;) FreeBSD "user"
"Intellectual Property" is nowhere near as valuable as "Intellect"
BOFH excuse #195:
We only support a 28000 bps connection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051209150907.1725f4c9>