From owner-cvs-all Fri Aug 3 23:22:49 2001 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 36FA537B403; Fri, 3 Aug 2001 23:22:44 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.4/8.11.4) with ESMTP id f746MLx15173; Sat, 4 Aug 2001 08:22:25 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Dima Dorfman Cc: Maxim Sobolev , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/md md.c In-Reply-To: Your message of "Fri, 03 Aug 2001 13:22:11 PDT." <20010803202216.30EB13E31@bazooka.unixfreak.org> Date: Sat, 04 Aug 2001 08:22:21 +0200 Message-ID: <15171.996906141@critter> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20010803202216.30EB13E31@bazooka.unixfreak.org>, Dima Dorfman writes: >Maxim Sobolev writes: >> sobomax 2001/08/02 03:19:14 PDT >> >> Modified files: >> sys/dev/md md.c >> Log: >> - Deny detaching requests until device is still open, otherwise it is possible >> to hang or panic kernel by detaching disk from which fs is mounted; > >When I proposed a similar patch some time ago, phk said that he would >like md(4) to behave "as much like a real disk as possible", which >included being able to go offline at any moment (in md terms, this >would mean detaching). This would be useful for testing such things >as a removable ATA flash drive going away. Right, I still feel that, but I also realize that POLA shouldn't be violated too much. I like you -force patch, it's a good compromise. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message