From owner-cvs-all Sun Sep 2 19: 7: 8 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 2E8FE37B401; Sun, 2 Sep 2001 19:07:01 -0700 (PDT) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 29C2C6ACF0; Mon, 3 Sep 2001 11:36:58 +0930 (CST) Date: Mon, 3 Sep 2001 11:36:58 +0930 From: Greg Lehey To: Poul-Henning Kamp Cc: Matt Dillon , Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Yet another style(9) bogon (was: cvs commit: src/sys/kern subr_prof.c kern_ntptime.c kern_xxx.c) Message-ID: <20010903113657.L59668@wantadilla.lemis.com> References: <200109010827.f818RW370778@earth.backplane.com> <69327.999413477@critter> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <69327.999413477@critter>; from phk@critter.freebsd.dk on Sun, Sep 02, 2001 at 08:51:17AM +0200 Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sunday, 2 September 2001 at 8:51:17 +0200, Poul-Henning Kamp wrote: > In message <200109010827.f818RW370778@earth.backplane.com>, Matt Dillon writes: >> >>> static void >>> usage() >>> { >>> /* Insert an empty line if the function has no local variables. */ >> >> You must be joking. Who came up with that carp? A blank line if >> the function has no local variables? In my entire life as a programmer >> I have never once seen that style. It looked like a mistake. If I >> see any more I won't take out the blank line but... no, I don't want to >> know whos idea it was. > > Well, there must be a lot of the FreeBSD kernel you have never looked at. Or noticed this particular wrinkle. Just because things look broken doesn't mean that it has to be because of style(9). > It's very convenient to know that the first blank line in a function > means the end of local variables, it makes simple source-munging > scripts much easier. Hmm. And I thought that style(9) was supposed to make it easier for humans to read the source, not for programs. > Until such time as you negotiate a change in style(9) on this point, > you are just as bound by it as any other committer. I don't see any evidence that Matt wanted to ignore it; quite the contrary, he said he would abide by it. I agree wholeheartedly that it looks bloody silly. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message