From owner-svn-src-all@freebsd.org Sun Jul 28 16:11:24 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D1572AEA54; Sun, 28 Jul 2019 16:11:24 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B754F6C0F2; Sun, 28 Jul 2019 16:11:23 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 45xSVW1M26z3ksN; Sun, 28 Jul 2019 16:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=daemonic.se; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received; s=20151023; t=1564330274; bh=olWekjUVTsy6P2bL8wmEMzIX Dn2/snIVtsndBs70h1w=; b=cImCrWhtWBwq6jZfyFbqPrlF/ViP0rt70ZpW0wxu UthV+4oKCAfjtht8cIeqQ7ismMBVJS3kDL5QSxnx+WDB0lU6AnEgoGd7RTm5OHcu vt3J9vXsXoizlEs1cxxzbsnMZYLjvxvPrns4uihb/3gXs79dvo8moy0JLV4qg+G2 vgI= X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id vcm2nqpSBhOm; Sun, 28 Jul 2019 16:11:14 +0000 (UTC) Received: from vivi.daemonic.se (vivi.daemonic.se [IPv6:2001:470:dca9:2::4]) by mail.daemonic.se (Postfix) with ESMTPSA id 45xSVT5fw7z3c7W; Sun, 28 Jul 2019 16:11:13 +0000 (UTC) Subject: Re: svn commit: r350390 - head/sys/kern To: Alan Somers , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201907281607.x6SG7SV3080649@repo.freebsd.org> From: Niclas Zeising Message-ID: Date: Sun, 28 Jul 2019 18:11:02 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <201907281607.x6SG7SV3080649@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B754F6C0F2 X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=daemonic.se header.s=20151023 header.b=cImCrWht; dmarc=pass (policy=none) header.from=daemonic.se; spf=pass (mx1.freebsd.org: domain of zeising@daemonic.se designates 176.58.89.161 as permitted sender) smtp.mailfrom=zeising@daemonic.se X-Spamd-Result: default: False [-7.71 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[daemonic.se:s=20151023]; NEURAL_HAM_MEDIUM(-0.99)[-0.991,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-3.73)[ip: (-9.83), ipnet: 176.58.89.0/24(-4.91), asn: 36236(-3.87), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; MX_GOOD(-0.01)[mail.daemonic.se]; DKIM_TRACE(0.00)[daemonic.se:+]; DMARC_POLICY_ALLOW(-0.50)[daemonic.se,none]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US]; TAGGED_FROM(0.00)[freebsd]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2019 16:11:24 -0000 On 2019-07-28 18:07, Alan Somers wrote: > Author: asomers > Date: Sun Jul 28 16:07:27 2019 > New Revision: 350390 > URL: https://svnweb.freebsd.org/changeset/base/350390 > > Log: > Better comments for vlrureclaim > > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/kern/vfs_subr.c > > Modified: head/sys/kern/vfs_subr.c > ============================================================================== > --- head/sys/kern/vfs_subr.c Sun Jul 28 15:20:47 2019 (r350389) > +++ head/sys/kern/vfs_subr.c Sun Jul 28 16:07:27 2019 (r350390) > @@ -947,9 +947,16 @@ vattr_null(struct vattr *vap) > * desirable to reuse such vnodes. These conditions may cause the > * number of vnodes to reach some minimum value regardless of what > * you set kern.maxvnodes to. Do not set kern.maxvnodes too low. > + * > + * @param mp Try to reclaim vnodes from this mountpoint > + * @param reclaim_nc_src Only reclaim directories with outgoing namecache > + * entries if this argument is strue > + * @param trigger Only reclaim vnodes with fewer than this many resident > + * pages. > + * @return The number of vnodes that were reclaimed. > */ > static int > -vlrureclaim(struct mount *mp, int reclaim_nc_src, int trigger) > +vlrureclaim(struct mount *mp, bool reclaim_nc_src, int trigger) > { > struct vnode *vp; > int count, done, target; > @@ -1238,7 +1245,8 @@ vnlru_proc(void) > { > struct mount *mp, *nmp; > unsigned long onumvnodes; > - int done, force, reclaim_nc_src, trigger, usevnodes; > + int done, force, trigger, usevnodes; > + bool reclaim_nc_src; > > EVENTHANDLER_REGISTER(shutdown_pre_sync, kproc_shutdown, vnlruproc, > SHUTDOWN_PRI_FIRST); Was this change intended? It's not mentioned in the commit message. Thanks! Regards -- Niclas