From owner-freebsd-current@freebsd.org Wed Oct 23 19:51:14 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5BEB415BEC5; Wed, 23 Oct 2019 19:51:14 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46z1G94ggLz4bSR; Wed, 23 Oct 2019 19:51:13 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: by mail-vk1-xa44.google.com with SMTP id d66so4733608vka.2; Wed, 23 Oct 2019 12:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y7gVZiIrsz6LWOYsQvASzFRjJA15ZqkVvdOHVY8eu9Y=; b=OOJfvz4zRjPPbX41FYoPFHxWMnTaryeLytHPIaonMKia55/GmBlkKGhvZeE8nhQBJd IlPrDWgChfwX8HhCuISox9A+70aMIRQImtMKbb1jLKwDMBgPloAg0l12WIVXhLdlBtrD AE9CxzBqtmiTjgaAXe3UaaEDMGfxpzOcXLt/zD7dKZr7rXIuMF4SSmic2bCxktpg9I50 z50J7Kvvaty1rtCuO+B9z8kW99nqwvCASxjiJXzwxEDZzAPtqpF8g0kQgMLNJV6XAX2w WeXI0uugTc1M/eqyV3PZXzJTokCtKvAsocpTFENUT/vJRrjDheChEXApnRP+f1uCt72I lt/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y7gVZiIrsz6LWOYsQvASzFRjJA15ZqkVvdOHVY8eu9Y=; b=Ko6/3tlDHH81bTtA1gcBsaqEDAGCnQNY+zKEjiDihaxQttGnpH4YK1TFZYTL9tnA84 XGtTqyoZK4nQw7MS44T5CLWKmvdOHwuVr9VheX7JBJxge3o9VrDH8nsHqw/WqYt8ixJh /4LJTk8vWaejJ1fAwoGg2RhVKHoK+oo+vT1T/3ran+4FjMgwxDaAe6vOPSunZxQdoJfN dtDPAwqs8ANpqXW4zGy59Uriw3b614Cp7UwRUbnNXSgTwb0DR2WGs/xTGRtn8pW8X5Zz aG55joNpQzhYRaerFwM1bxqLUJ7+O1PnSgxLAOXB7+1hXaZrrCjHyaS+hJ+89Ywj9m4z rCCQ== X-Gm-Message-State: APjAAAXIFnCl/tI+C/nOQE+rgXoAXXHcjYHIsLrAdxctrea7FONS6K2S rids2I013D3irLCOEm+luDgYBkdS3UKHPKQENg== X-Google-Smtp-Source: APXvYqye3thwXGQshRTswkxJrOFyvSAb+c+y2p7zQWQAJ2VXQb23r9+034JaFWrpfXKso3IatDHny3cdZ1iOL0Y5HNo= X-Received: by 2002:a05:6122:336:: with SMTP id d22mr5868592vko.4.1571860271450; Wed, 23 Oct 2019 12:51:11 -0700 (PDT) MIME-Version: 1.0 References: <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> <20191017195347.GB6447@raichu> <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> <20191017210510.GC6447@raichu> <96d8f37a-179b-ecad-62d1-5a097d30c0ed@daemonic.se> <29e29759-18bc-6747-ab11-e15eea4ac738@daemonic.se> In-Reply-To: <29e29759-18bc-6747-ab11-e15eea4ac738@daemonic.se> From: "Clay Daniels Jr." Date: Wed, 23 Oct 2019 14:50:59 -0500 Message-ID: Subject: Re: DRM-current-kmod is still a problem at r353339 To: Niclas Zeising Cc: Mark Johnston , Neel Chauhan , Mateusz Guzik , Evilham , FreeBSD Current , owner-freebsd-current@freebsd.org X-Rspamd-Queue-Id: 46z1G94ggLz4bSR X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=OOJfvz4z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of claydanielsjr@gmail.com designates 2607:f8b0:4864:20::a44 as permitted sender) smtp.mailfrom=claydanielsjr@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[4.4.a.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (2.29), ipnet: 2607:f8b0::/32(-2.42), asn: 15169(-2.06), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2019 19:51:14 -0000 r353709 Looked promising, but failed: Loaded r353709 make install drm-kmod, all 3 installed (drm-devel-kmod, drm-current-kmod, & gpu-firmware-kmod) set /etc/rc.conf & /boot/loader.conf configs as usual rebooted and looked good, video tingling pkg install xorg rebooted and ran startx panic: vm_page_assert_xbusied: page 0xfffffe0005057500 not exclusive busy @ /usr/src/sys/vm/vm_page.c System: Ryzen 7 3700X, MSI 570 series motherboard & video card Thanks for trying, Clay On Wed, Oct 23, 2019 at 3:42 AM Niclas Zeising wrote: > On 2019-10-21 10:13, Niclas Zeising wrote: > > On 2019-10-17 23:05, Mark Johnston wrote: > >> On Thu, Oct 17, 2019 at 10:31:12PM +0200, Niclas Zeising wrote: > >>> On 2019-10-17 21:53, markj@freebsd.org wrote: > >>>> On Thu, Oct 17, 2019 at 03:03:51PM +0200, Niclas Zeising wrote: > >>>>> On 2019-10-16 18:57, Neel Chauhan wrote: > >>>>>> While drm-current-kmod worked for a little while, it broke with > >>>>>> r353645. > >>>>>> > >>>>>> https://i.imgur.com/Q5nYZf2.jpg > >>>>>> > >>>>>> I'm using the same HP Spectre that I used earlier (where it worked > >>>>>> and > >>>>>> where it panicked). > >>>>>> > >>>>> > >>>>> That commit looks unrelated, it touches the wbwd and superio drivers, > >>>>> nothing else. Any chance you can bisect exactly which revision that > >>>>> caused the new issues? > >>>> > >>>> I believe it was the recent work on the vm page busy state, r353539 > >>>> specifically. This patch should fix it; we don't yet have a > >>>> __FreeBSD_version number bump on which to gate the patch. > >>>> > >>>> diff --git a/linuxkpi/gplv2/src/linux_page.c > >>>> b/linuxkpi/gplv2/src/linux_page.c > >>>> index e2b85c45c..060ae85ed 100644 > >>>> --- a/linuxkpi/gplv2/src/linux_page.c > >>>> +++ b/linuxkpi/gplv2/src/linux_page.c > >>>> @@ -239,7 +239,7 @@ retry: > >>>> page = vm_page_lookup(devobj, i); > >>>> if (page == NULL) > >>>> continue; > >>>> - if (vm_page_sleep_if_busy(page, "linuxkpi")) > >>>> + if (!vm_page_busy_acquire(page, VM_ALLOC_WAITFAIL)) > >>>> goto retry; > >>>> cdev_pager_free_page(devobj, page); > >>>> } > >>> > >>> Hi! > >>> Hopefully someone can confirm that this patch to drm-current-kmod or > >>> drm-devel-kmod fixes the issue. I won't be able to work on this before > >>> the weekend at the earliest, I'm afraid. > >>> Mark, is it possible to get a belated version bump for this fix, and > >>> what changed to require it? > >> > >> I committed the bump and verified the patch on amdgpu. Here are some > >> PRs for the drivers: > >> > >> https://github.com/FreeBSDDesktop/kms-drm/pull/180 > >> https://github.com/FreeBSDDesktop/kms-drm/pull/181 > > > > Hi! > > I'm working on getting this into the versions that are in ports. For > > drm-current-kmod it's fairly simple, but for drm-devel-kmod there are > > unrelated changes which I need to check if they are ready to go in or > > not, so it will take some more time. > > > > Looking at the mail list thread, there seems to be a patch needed for > > base as well, has this been committed? > > drm-devel-kmod and drm-current-kmod has been updated with the above fix. > If there are further issues, please let us know. > Regards > -- > Niclas > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >