From owner-freebsd-wireless@freebsd.org Thu Jun 7 04:41:01 2018 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69D3EFF6109 for ; Thu, 7 Jun 2018 04:41:01 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB9F07D2D3 for ; Thu, 7 Jun 2018 04:40:40 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: by mail-it0-x230.google.com with SMTP id 76-v6so11152610itx.4 for ; Wed, 06 Jun 2018 21:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=xNa5Gj9A417xnbZGm7Hs98U5NCpJs9ig4rF5FXCRuPo=; b=PdYWWnSStJek+R3znTjMBbhqVr+SgTQepelG+4mpxEPAMFe+BUK8Dt11w2wKoguvAj 1f2jdY5Qv1hrOixCllAh9aekC69Jsap2d8O38NdUHA2gItq6Riv31XDE/1onaxxYKOam reBpbdM/5lRR/eMFjB4utCiK1tvHeKZdREi34SnCIu2LkoXKw1D68TnTpRnBP6zM3f2E BbAHX0ymCq+cV82rHodZybvbUcjwpLyXgrpfB0R7tc3MQ3jScBv/q7CrMDuXcq24jRY+ 5ccU5VyyKjHO/0DFPaZZsF1BR5Daw1nPCzN47YKVwxrLfJSgKWCn7QE10YjSkrR1QuU6 eddQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xNa5Gj9A417xnbZGm7Hs98U5NCpJs9ig4rF5FXCRuPo=; b=F3Rm3bNsTc0QmwD7ZcUtL/Ni53GG1n3kJuoeG/OTW3rAbBbvydt6erkvYto1Q8agUc Oz04Qd8DDtZYHNzNVxmjzOoy5OSM33NbVMLqpTclu0zEA1vDSH0hFc44cuG+a3krXEo4 PPfGdGcw3Zi0DvHWAZU52UHaBldSPDSUljGuV82qwWtVzsquJ49QvUuQQcCm5c4bJWFp efkj/4xtG/p6UX2U+DSdhE/8rZp4uqu8UsoSNVjbIAwDSn8HLYu1BOW//Z1ZQJoch+uF J4jDIgdBFxP21Dw4hu8FpU6foyaY2wxOo40XMQq3gi/8IwZmyZinw3YONzdhBUmKt1Fg 2law== X-Gm-Message-State: APt69E3NJNfxYpIP4YH77/z1cgnMxT8jvI5wxf8athY1InVpXavacZYl 6TM60bLYf2c0S7AjGIqj/Cylt0CrHp5vYKMoahph4IN5 X-Google-Smtp-Source: ADUXVKIWZLToT3aggMrYsJAG8Y2fmXw1yaqT2D+olIv9Xlp+yZ8CvVR3PQACb1fXwdgs6jnDgJIQtT+7++me84LVJ9g= X-Received: by 2002:a24:ee4b:: with SMTP id b72-v6mr517608iti.43.1528346439747; Wed, 06 Jun 2018 21:40:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac0:a148:0:0:0:0:0 with HTTP; Wed, 6 Jun 2018 21:40:19 -0700 (PDT) From: Farhan Khan Date: Thu, 7 Jun 2018 00:40:19 -0400 Message-ID: Subject: Ignoring R92C_C2H_EVT_DEBUG patch To: freebsd-wireless@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 04:41:01 -0000 Quick patch to rtwn's signal handling. Ignoring R92C_C2H_EVT_DEBUG interrupts rtl8188ee sends debugging interrupts a few times a second, which contain no information. Linux's rtl8723ae also ignores this signal. Currently, rtl8188ee prints endless C2H unhandled reports to the kernel messages, such as this: rtwn0: r92c_handle_c2h_task: C2H report 0 (len 0) was not handled rtwn0: r92c_handle_c2h_task: C2H report 0 (len 0) was not handled rtwn0: r92c_handle_c2h_task: C2H report 0 (len 0) was not handled ..... My associated git commit is located here: https://gitlab.com/farhankhan/freebsd/commit/9f9ff4bd883a88788376876fb09bac017dbb13e2 ============================================================================== diff --git a/sys/dev/rtwn/rtl8192c/r92c_fw.c b/sys/dev/rtwn/rtl8192c/r92c_fw.c index 0791990a0c00..14e517636c14 100644 --- a/sys/dev/rtwn/rtl8192c/r92c_fw.c +++ b/sys/dev/rtwn/rtl8192c/r92c_fw.c @@ -477,6 +477,8 @@ r92c_handle_c2h_task(struct rtwn_softc *sc, union sec_param *data) __func__, i, sizeof(buf))); switch (id) { + case R92C_C2H_EVT_DEBUG: + break; case R92C_C2H_EVT_TX_REPORT: r92c_ratectl_tx_complete(sc, (uint8_t *)buf, len); break; ============================================================================== Thanks -- Farhan Khan PGP Fingerprint: B28D 2726 E2BC A97E 3854 5ABE 9A9F 00BC D525 16EE