Date: Thu, 17 Dec 2020 10:00:06 +0100 From: Stefan Esser <se@freebsd.org> To: Alan Somers <asomers@freebsd.org>, Allan Jude <allanjude@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-releng@freebsd.org, Martin Matuska <mm@FreeBSD.org> Subject: Re: svn commit: r365917 - in releng/12.2: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zpool sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolar... Message-ID: <a0ca9146-6a98-7dd2-96a6-3da73a66438c@freebsd.org> In-Reply-To: <CAOtMX2gShB9GXfC4QbOf9OuvJhfGt4tMqXbfTjXoPV0ofU0igQ@mail.gmail.com> References: <202009192046.08JKkuBn080241@repo.freebsd.org> <CAOtMX2gShB9GXfC4QbOf9OuvJhfGt4tMqXbfTjXoPV0ofU0igQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zYqNcUXDyA35iXSOG6OoT3xxvBfhPLMG5 Content-Type: multipart/mixed; boundary="q8JIM182Z3jcfg2mi7cRZVErtB1d0EnBI"; protected-headers="v1" From: Stefan Esser <se@freebsd.org> To: Alan Somers <asomers@freebsd.org>, Allan Jude <allanjude@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-releng@freebsd.org, Martin Matuska <mm@FreeBSD.org> Message-ID: <a0ca9146-6a98-7dd2-96a6-3da73a66438c@freebsd.org> Subject: Re: svn commit: r365917 - in releng/12.2: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zpool sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolar... References: <202009192046.08JKkuBn080241@repo.freebsd.org> <CAOtMX2gShB9GXfC4QbOf9OuvJhfGt4tMqXbfTjXoPV0ofU0igQ@mail.gmail.com> In-Reply-To: <CAOtMX2gShB9GXfC4QbOf9OuvJhfGt4tMqXbfTjXoPV0ofU0igQ@mail.gmail.com> --q8JIM182Z3jcfg2mi7cRZVErtB1d0EnBI Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 16.12.20 um 21:30 schrieb Alan Somers: > On Sat, Sep 19, 2020 at 2:47 PM Allan Jude <allanjude@freebsd.org=20 > <mailto:allanjude@freebsd.org>> wrote: >=20 > Author: allanjude > Date: Sat Sep 19 20:46:56 2020 > New Revision: 365917 > URL: https://svnweb.freebsd.org/changeset/base/365917 > <https://svnweb.freebsd.org/changeset/base/365917>; >=20 > Log: > =C2=A0 MFS r365689,r365808,r365860 >=20 > =C2=A0 MFOpenZFS: Introduce read/write kstats per dataset >=20 > =C2=A0 The following patch introduces a few statistics on reads an= d writes > =C2=A0 grouped by dataset. These statistics are implemented as kst= ats > =C2=A0 (backed by aggregate sums for performance) and can be retri= eved by > =C2=A0 using the dataset objset ID number. The motivation for this= change is > =C2=A0 to provide some preliminary analytics on dataset usage/perf= ormance. >=20 > =C2=A0 Reviewed-by: Richard Elling <Richard.Elling@RichardElling.c= om> > =C2=A0 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov > <mailto:behlendorf1@llnl.gov>> > =C2=A0 Reviewed by: Matthew Ahrens <mahrens@delphix.com > <mailto:mahrens@delphix.com>> > =C2=A0 Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.c= om > <mailto:serapheim@delphix.com>> >=20 > =C2=A0 openzfs/zfs@a448a2557ec4938ed6944c7766fe0b8e6e5f6456 >=20 > =C2=A0 Also contains parts of: > =C2=A0 MFOpenZFS: Connect dataset_kstats for FreeBSD >=20 > =C2=A0 Example output: > =C2=A0 kstat.zfs.mypool.dataset.objset-0x10b.nread: 150528 > =C2=A0 kstat.zfs.mypool.dataset.objset-0x10b.reads: 48 > =C2=A0 kstat.zfs.mypool.dataset.objset-0x10b.nwritten: 134217728 > =C2=A0 kstat.zfs.mypool.dataset.objset-0x10b.writes: 1024 > =C2=A0 kstat.zfs.mypool.dataset.objset-0x10b.dataset_name: > mypool/datasetname >=20 > =C2=A0 Reviewed-by: Ryan Moeller <ryan@iXsystems.com> > =C2=A0 Reviewed by: Sean Eric Fagan <sef@ixsystems.com > <mailto:sef@ixsystems.com>> > =C2=A0 Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com= > <mailto:serapheim@delphix.com>> > =C2=A0 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov > <mailto:behlendorf1@llnl.gov>> > =C2=A0 Signed-off-by: Allan Jude <allan@klarasystems.com > <mailto:allan@klarasystems.com>> >=20 > =C2=A0 openzfs/zfs@4547fc4e071ceb1818b3a46c3035b923e06e5390 >=20 > =C2=A0 Approved by:=C2=A0 re (gjb) > =C2=A0 Relnotes:=C2=A0 =C2=A0 =C2=A0yes > =C2=A0 Sponsored by: Klara Inc. >=20 >=20 > This sounds quite useful!=C2=A0 I've often wished that I could see=20 > per-dataset traffic statistics.=C2=A0 Are there any user-friendly front= ends=20 > to this?=C2=A0 Like zfs-stats, or an updated zpool iostat? I have updated zfs-stats for OpenZFS a few months ago and I'd be willing to add printing these new values to the port. The maintainer of the upstream version had little interest to accept my patches into his repository (after sending several request) and thus I have added a large patch to the port. If further changes are applied, I might fork the upstream repository and base the zfs-stats port on that fork (but I did not want to grab it without the current maintainer agreeing ...) Regards, STefan --q8JIM182Z3jcfg2mi7cRZVErtB1d0EnBI-- --zYqNcUXDyA35iXSOG6OoT3xxvBfhPLMG5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl/bHhYFAwAAAAAACgkQR+u171r99UQD +wgAhJwNnTA8JGBERdk5qU4cgGq0FUn+o2utm5kAbL/23SzkhJi00pCl+qirWzaxIpmEOZwUm9Xz cG/s/UvFYTJ9hboWWPBLf7df0I3ExNeyYIpqXKVfNfdDwNbBlXtz8VJFXRibkzLfI5Ax6+hk97Ll MoI3uLvZ2sLTUeOnb9/rByKXEbuoSCcm0kMc5HqPbyGQyBMfBsGvH3MjDnSLvGeT+45fJbG9Kezj RyBC8aKmrx8P4LHrFK1F5Idh7jKw86iZ5XFjWnmu3CyvVfGDWDboPQP6sIEHvFrVDcr0mGMCWf+k yFqHR8kPaNrX8SBcv4IqbFC2OR5eyOLck3GqDFfKAg== =NecG -----END PGP SIGNATURE----- --zYqNcUXDyA35iXSOG6OoT3xxvBfhPLMG5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a0ca9146-6a98-7dd2-96a6-3da73a66438c>