From owner-freebsd-multimedia@freebsd.org Thu Aug 15 10:13:26 2019 Return-Path: Delivered-To: freebsd-multimedia@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F4FFCD0D8 for ; Thu, 15 Aug 2019 10:13:26 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 468MjL0qpDz4gGP for ; Thu, 15 Aug 2019 10:13:26 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: by mailman.nyi.freebsd.org (Postfix) id 1A987CD0D7; Thu, 15 Aug 2019 10:13:26 +0000 (UTC) Delivered-To: multimedia@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 192E3CD0D6 for ; Thu, 15 Aug 2019 10:13:26 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468MjK12tkz4gGN; Thu, 15 Aug 2019 10:13:24 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 36F5633E59; Thu, 15 Aug 2019 06:13:23 -0400 (EDT) Received: from anthias (unknown [178.114.243.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 75F7E33E52; Thu, 15 Aug 2019 06:13:22 -0400 (EDT) Date: Thu, 15 Aug 2019 12:13:47 +0200 (CEST) From: Gerald Pfeifer To: Arne Steinkamm , multimedia@FreeBSD.org cc: Jan Beich Subject: Re: Patch for port avidemux-plugins In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 468MjK12tkz4gGN X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-5.48 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; RCVD_IN_DNSWL_NONE(0.00)[143.5.68.209.list.dnswl.org : 127.0.10.0]; IP_SCORE(-2.21)[ip: (-8.01), ipnet: 209.68.0.0/18(-1.84), asn: 7859(-1.13), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 10:13:26 -0000 On Thu, 15 Aug 2019, Arne Steinkamm wrote: > avidemux-plugins failed to build because the source redefine the magic > constant __cplusplus which breaks the gcc8 header files. > > I made a fast patch which works here (FreeBSD trajan.stk.cx 12.0-RELEASE-p7 > FreeBSD 12.0-RELEASE-p7 r350232 TRAJAN amd64): Thank you for the report and patch, Arne! Note that I do not have any knowledge of this port (and assume you directed this to me in addition to Jan due to r507372, "Bump PORTREVSION for ports depending on the canonical version of GCC). Let me include multimedia@FreeBSD.org which is listed as maintainer of the port. Gerald > --- /usr/ports/multimedia/avidemux-plugins/Makefile.orig 2019-07-19 > 23:11:01.000000000 +0200 > +++ /usr/ports/multimedia/avidemux-plugins/Makefile 2019-08-15 > 05:24:36.904761000 +0200 > @@ -35,4 +35,8 @@ > > post-configure: post-configure-common > > +pre-build: > + @${REINPLACE_CMD} 's|#define __cplusplus|#define __cplusplus 201402L|g' \ > + ${WRKSRC}/avidemux_plugins/ADM_demuxers/VapourSynth/ADM_vsProxy.h > + > .include >