From owner-freebsd-stable@freebsd.org Mon Mar 29 22:10:32 2021 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 793E35AD405 for ; Mon, 29 Mar 2021 22:10:32 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F8RbW5BzFz4ltF for ; Mon, 29 Mar 2021 22:10:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f50.google.com with SMTP id w21-20020a9d63950000b02901ce7b8c45b4so13748935otk.5 for ; Mon, 29 Mar 2021 15:10:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cm5Feqjwi7Nnhgmh4DGUS6l3wNLYCaVoki/eVpAv69U=; b=r15uienot2lv7LR8qWuK4szp+wD8uYENj0eDfGmVDeQFpkbq1jz65Bfq+wfq0iILK7 M6ovv8jlJNVT+QJdEwezyrhWB/bIv13oWdjBgtmReCvKtpkQ08yBzDGmm11Cl7hED+R7 YvjBkfhApPL3oNvh7ZNurPOvqQw+5ykCRcPZtijFc9wvUK6K5gpFQBx19u2PcZ3spR1r 6Jgx0+Z16XO4Ek200RUtV2tE6rZ9Zrnp5eajz1u+5Np3YFmWw3JgLgeWHYL/oJo5I7zq lu6ca/wqxvlRnF6eKWwZwzyb0iIcLSocU66P75FYSsafsoK4BhrpkjN6Cf0XdYj09UH1 Rntw== X-Gm-Message-State: AOAM530vI8PQJzIl7iDyRG7zsDOnpOjF+6UwRrHiwlQDTmh+jmUEGzg3 dTJXQxGf/BjDP+++4/IxjStthzwgdwKvuzTViDZ6d5/W X-Google-Smtp-Source: ABdhPJy0cvlxDvK6ydbqjm7SMIb8DtwbQxfM49toFfvZ/7pBjJg1IiZKoB+vrg7roNedCYGbUO4yNMeLnAAJfH5ldes= X-Received: by 2002:a05:6830:1af6:: with SMTP id c22mr23275805otd.291.1617055830548; Mon, 29 Mar 2021 15:10:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Mon, 29 Mar 2021 16:10:19 -0600 Message-ID: Subject: Re: FreeBSD NFSv4.1/4.2 server is broken when Linux mounts use "nconnects" To: Rick Macklem Cc: freebsd-stable X-Rspamd-Queue-Id: 4F8RbW5BzFz4ltF X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RWL_MAILSPIKE_GOOD(0.00)[209.85.210.50:from]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.999]; RCPT_COUNT_TWO(0.00)[2]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.210.50:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.210.50:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.210.50:from]; R_DKIM_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-stable] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2021 22:10:32 -0000 On Mon, Mar 29, 2021 at 3:52 PM Rick Macklem wrote: > Hi, > > The FreeBSD NFS server is broken when handling multiple > connections for NFSv4.1/4.2. > It incorrectly binds the back channel to a new connection > when is sees an RPC with Sequence in it (almost all RPCs) > and might send a callback on the wrong connection. > > I have a fix, but it won't be in a release until 12.3/13.1. > It can be found in Bugzilla PR#254560. > > In the meantime, avoid using the "nconnects" option > on Linux client mounts. > > Thanks go to Ben Coddington @redhat for diagnosing > this and testing the patch. > > Sorry about the breakage, rick > ps: It was done intentionally long ago, when clients > did not do BindConnectionToSession and then slipped > through the cracks. > Since the bug involves callbacks, would disabling delegations be a valid workaround?